HomeSolus

subtitlecomposer: disable libmpv backend

Authored by aleksvor on Nov 23 2020, 6:12 PM.

Description

subtitlecomposer: disable libmpv backend

Summary:
mpv backend relies on qthelper.hpp header, which was removed in mpv 0.33.0. While it's possible to provide this header in source tree of Subtitle Composer (that's what mpv recommends downstreams to do), I think it's not necessary:

  1. GStreamer backend is still functional and on par with mpv backend.
  2. Upstream Subtitle Composer don't even support these backends anymore - they have removed them in favor of unified backend based on FFmpeg and OpenGL.

Depends on D10020.

Test Plan: Loaded MKV container with English subtitles. Checked that Gstreamer player backend can playback the video, render original subtitles and my translated subtitles.

Reviewers: Triage Team, JoshStrobl

Reviewed By: Triage Team, JoshStrobl

Subscribers: JoshStrobl, livingsilver94

Differential Revision: https://dev.getsol.us/D10021

Details

Committed
JoshStroblNov 23 2020, 6:13 PM
Pushed
JoshStroblNov 23 2020, 6:13 PM
Reviewer
Triage Team
Differential Revision
D10021: subtitlecomposer: disable libmpv backend
Parents
R4928:ad7f3237238d: Safety rebuild subtitlecomposer for Framework update
Branches
Unknown
Tags
Unknown
References
tag: subtitlecomposer-0.7.0-3