HomeSolus
Diffusion atom 2dc2803ba63f

Fix project indexing, which was preventing use of Find File (Ctrl+P).

Authored by JoshStrobl on Sep 12 2019, 7:47 AM.

Description

Fix project indexing, which was preventing use of Find File (Ctrl+P).

This appears to be the result of Atom's git-utils package vendoring libgit2 during 5.6.0 and 5.6.1 at an incorrect point in libgit2's history, where there was an ABI change where gitno_connection_data was renamed to get_net_url. This landed on June 11th, per this pull request but doesn't account for subsequent commits to src/net.c, realistically they should sort out their submodule or not rely on it in the first place. This new git-utils package was pulled in specifically for 1.41.0 and thus reverting it 5.5.0 from 1.40.0 resolves the issue.

Alongside this change I also went ahead and removed some long unnecessary node engine min / max version comparisons.

Details

Committed
JoshStroblSep 12 2019, 7:56 AM
Pushed
JoshStroblSep 12 2019, 7:56 AM
Parents
R394:d093b71c4440: Update atom to 1.40.1
Branches
Unknown
Tags
Unknown
References
tag: atom-1.40.1-126

Event Timeline

FYI Atom has closed the issue, so Solus has a non-functional Atom editor:

https://github.com/atom/design-decisions/blob/master/unofficial-atom-distributions.md

https://github.com/atom/find-and-replace/issues/1103#issuecomment-539185933

I'd like to help if I can but I'm unsure where to start.

(I've currently moved over to ubuntu-budgie for the time being :( )

FYI Atom has closed the issue, so Solus has a non-functional Atom editor:
https://github.com/atom/design-decisions/blob/master/unofficial-atom-distributions.md
https://github.com/atom/find-and-replace/issues/1103#issuecomment-539185933
I'd like to help if I can but I'm unsure where to start.
(I've currently moved over to ubuntu-budgie for the time being :( )

Please file a task with us (as I've requested before), commenting on a commit isn't the right way for this to be tracked, investigated, and addressed. Hopefully it is something @Jacalz can look into, as he is the maintainer of Atom.

Jacalz added a comment.Oct 8 2019, 6:25 PM
This comment was removed by Jacalz.