HomeSolus

Switch to i3lock-color for T4589

Authored by Federico Damián Schonborn <federicodamiansch@gmail.com> on Dec 15 2017, 10:13 AM.

Description

Switch to i3lock-color for T4589

Summary:
This fork includes these new features:

  • Color options for the following:
    • Verification ring
    • Interior ring color
    • Ring interior line color
    • Key highlight color
    • Backspace highlight color
    • Text colors for most/all strings
    • Changing all of the above depending on PAM's authentication status
  • Blurring the current screen and using that as the lock background
  • Showing a clock in the indicator
  • refreshing on a timer, instead of on each keypress
  • Positioning the various UI elements
  • Changing the ring radius and thickness, as well as text size
  • A new bar indicator, which replaces the ring indicator with its own set of options
    • An experimental thread for driving the redraw ticks, so that things like the bar/clock still update when PAM is blocking

Resolves T4589.

Signed-off-by: Federico Damián Schonborn <federicodamiansch@gmail.com>

Test Plan: Executed it a few times, I was capable of unlocking my desktop normally.

Reviewers: Triage Team, JoshStrobl

Reviewed By: Triage Team, JoshStrobl

Subscribers: JoshStrobl

Maniphest Tasks: T4589

Differential Revision: https://dev.solus-project.com/D1645

Details

Committed
JoshStroblDec 15 2017, 10:13 AM
Pushed
JoshStroblDec 15 2017, 10:13 AM
Reviewer
Triage Team
Differential Revision
D1645: Switch to i3lock-color for T4589
Parents
R1440:652b7e28bcb7: Update to 2.10
Branches
Unknown
Tags
Unknown
References
tag: i3lock-2.10.1-7
Reverted By
R1440:da75d1893f3b: Revert "Switch to i3lock-color for T4589"
Tasks
T4589: i3lock-fancy

Event Timeline

JoshStrobl added a subscriber: JoshStrobl.EditedDec 15 2017, 8:21 PM

I'm sorry but there is absolutely no way this was tested. It immediately segfaults with Illegal Instruction, then even after compiling against the latest commit in master, will spew memory leak errors, which can only be fixed by applying a patch that you must manually rebase on top of i3lock-color and i3lock.

This is not how I wanted to spend my Friday night. I'm reverting the commit.