Specifying openssl-devel and libxml2-devel's pkgconfigs isn't necessary, they're in system.devel. Also not seeing why pinentry is needed as builddep, not seeing any indication it is needed. Is their cmake checking it for some reason?

@JoshStrobl @ikey - Thanks for the feedback. I'll pull openssl-develand libxml2-devel out. I thought it was worth being explicit, but happy to remove since as you said they're in system.devel

Looking more at pinentry, I think you're right that it's an (optional) runtime dependency.

They call out them all out together: https://github.com/lastpass/lastpass-cli#dependencies and in the other distro install instructions they call out installing them all together.

It seems primarily used in password.[c,h] and upload_queue.c https://github.com/lastpass/lastpass-cli/search?utf8=%E2%9C%93&q=pinentry&type=

But I think it's the same with xclip. if it's installed, it will use it. I think it's worth having both, but they're not 'hard' dependencies since there are fallbacks. Maybe remove and let users do what they want?

Yeah remove pinentry, no sense hard-coding it. It's up to gpg to use it, not lastpass. Which is how everyone already has it installed in the default ISO :)

remove system.devel pkgs, pinentry

One note on the docs [1] for Fixing a patch that needs changes. After running arc diff I received a prompt to enter a message. It wasn't entirely clear whether this was optional or what it was for. Though it did mention my existing ticket, which was cool. Clearly it adds a comment to go along with the changes, which is great. Maybe call that out? Something like what's written in the arc diff section above?

"A new editor session will open, where you can provide details about the changes you've made in your amended commit. This content will be used by arc to create a new comment in your ticket on the Solus Dev Portal, along with your amended commit". Or something like that?