Differential D9946

Update lazygit to 0.23.7
ClosedPublic
Actions

Authored by davidjharder on Nov 9 2020, 2:52 PM.

Tags

None

Referenced Files

	F11020565: D9946.id23940.diff
	Mon, Aug 7, 6:44 AM

	F10970460: D9946.id23940.diff
	Fri, Jul 21, 2:32 AM

	F10858585: D9946.id23940.diff
	Jun 15 2023, 4:57 PM

	F10852506: D9946.id23952.diff
	Jun 13 2023, 1:12 AM

	F10849417: D9946.id23922.diff
	Jun 11 2023, 7:38 PM

	F10833878: D9946.diff
	Jun 7 2023, 3:43 AM

	F10777649: D9946.id.diff
	May 23 2023, 11:37 PM

	F10776288: D9946.id.diff
	May 23 2023, 9:19 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

R5033:40d746f33f2f: Update lazygit to 0.23.7

Summary

Summarized Changelog

Prevent crash when removing remote with no URLs
Copy a commit message to clipboard: Changes to latest version
More password checks on commands that talk to the remote
Preserve width of side panel when main view split unless window is wide enough
Support rebinding confirm/newline keys in editor

Full changelogs here, here, here, here, and finally here

Test Plan

Perform some basic git commands: commit, pull, push.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

davidjharder created this revision.Nov 9 2020, 2:52 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 9 2020, 2:52 PM

davidjharder requested review of this revision.Nov 9 2020, 2:52 PM

Could you look at improving the manpage? Right now most of it is installation instructions for different OSes, which are useless as you already have installed it. I don't know if you could trim most of it during the packaging or maybe report that to the original author?

davidjharder added a comment.Nov 9 2020, 5:15 PM

This comment was removed by davidjharder.

@Jacek I removed my previous comment because it was wrong.

You are right, the man page is just the README. I had forgotten that this discussion already happened once on D9190. Lazygit does not provide a man page.

This discussion did not make it obvious that the man page is useless. The only comment regarding the man page is kyrios saying " The man page is available anyway."

Without seeing the contents of the manpage and knowing that lazygit is "special" in that they don't actually provide one, every other software that provides correct man pages would just train us to assume that lazygit provides one as well.

Since that isn't the case, we should just remove it.

This revision now requires changes to proceed.Nov 10 2020, 8:16 PM

Remove the useless man page

LGTM, thanks!

This revision is now accepted and ready to land.Nov 12 2020, 11:18 AM

Closed by commit R5033:40d746f33f2f: Update lazygit to 0.23.7 (authored by davidjharder, committed by JoshStrobl). · Explain WhyNov 12 2020, 11:19 AM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R5033:40d746f33f2f: Update lazygit to 0.23.7.

Revision Contents
Changeset List

Path

Size

10 lines

pspec_x86_64.xml

7 lines

Diff 23952

package.yml

Loading...

pspec_x86_64.xml

Loading...