Page MenuHomeSolus

Update lazygit to 0.23.7

Authored by davidjharder on Nov 9 2020, 2:52 PM.



Summarized Changelog

  • Prevent crash when removing remote with no URLs
  • Copy a commit message to clipboard: Changes to latest version
  • More password checks on commands that talk to the remote
  • Preserve width of side panel when main view split unless window is wide enough
  • Support rebinding confirm/newline keys in editor

Full changelogs here, here, here, here, and finally here

Test Plan

Perform some basic git commands: commit, pull, push.

Diff Detail

R5033 lazygit
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

davidjharder created this revision.Nov 9 2020, 2:52 PM
davidjharder requested review of this revision.Nov 9 2020, 2:52 PM
Jacek added a subscriber: Jacek.Nov 9 2020, 4:39 PM

Could you look at improving the manpage? Right now most of it is installation instructions for different OSes, which are useless as you already have installed it. I don't know if you could trim most of it during the packaging or maybe report that to the original author?

This comment was removed by davidjharder.
davidjharder added a comment.EditedNov 9 2020, 6:05 PM

@Jacek I removed my previous comment because it was wrong.

You are right, the man page is just the README. I had forgotten that this discussion already happened once on D9190. Lazygit does not provide a man page.

JoshStrobl requested changes to this revision.Nov 10 2020, 8:16 PM
JoshStrobl added a subscriber: JoshStrobl.

This discussion did not make it obvious that the man page is useless. The only comment regarding the man page is kyrios saying " The man page is available anyway."

Without seeing the contents of the manpage and knowing that lazygit is "special" in that they don't actually provide one, every other software that provides correct man pages would just train us to assume that lazygit provides one as well.

Since that isn't the case, we should just remove it.

This revision now requires changes to proceed.Nov 10 2020, 8:16 PM

Remove the useless man page

JoshStrobl accepted this revision.Nov 12 2020, 11:18 AM

LGTM, thanks!

This revision is now accepted and ready to land.Nov 12 2020, 11:18 AM
This revision was automatically updated to reflect the committed changes.