Page MenuHomeSolus

Update pan to version 0.146
ClosedPublic

Authored by abnazhor on Thu, Nov 5, 9:19 AM.

Details

Summary
  • Fixes
    • Update .gitlab-ci.yml with GTK 3
    • Use an int instead of a char
    • Fix for segfault when build with gmime-3
    • Fix to build Pan with options --with-gmime30 and --with-gmime-crypto
    • Update bug URLs
    • Replace Bugzilla by Gitlab URL in DOAP file
    • Fix ypart begin for bpf ranges
    • Update URLs to GitLab
    • Module was renamed to pan
Test Plan
  • Join a news server
  • Edit news servers
  • Download headers from different groups
  • Modify preferences
  • Remove news server
  • Publish news

Diff Detail

Repository
R2287 pan
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

abnazhor requested review of this revision.Thu, Nov 5, 9:19 AM
abnazhor created this revision.
abnazhor retitled this revision from Update package to version 0.146 to Update pan to version 0.146.Thu, Nov 5, 9:39 AM
algent added a subscriber: algent.Thu, Nov 5, 10:34 AM

There is also task about this, T9310. If you want to be the maintainer you can add to your Summary in a new line Resolve T9310

abnazhor updated this revision to Diff 23894.Thu, Nov 5, 11:11 AM
  • Add MAINTAINERS.md file.

I have added a MAINTAINERS.md file instead. Is it correct? @algent

Hi @abnazhor, nice job so far. You are near.
now remove REPLACEME from MAINTAINERS.md file.

- REPLACEME Jorge Barrera
  - IRC: abnazhor
  - Email: jorbar982@protonmail.com

It should be.

- Jorge Barrera
  - IRC: abnazhor
  - Email: jorbar982@protonmail.com

Also check the license in package.yml file. It should be GPL-2.0-only or GPL-2.0-or-later and then rebuild again to update pspec_x86_64.xml.

abnazhor updated this revision to Diff 23895.Thu, Nov 5, 11:55 AM
  • Remove REPLACEME string from MAINTAINERS.md
abnazhor updated this revision to Diff 23896.Thu, Nov 5, 12:00 PM
  • Change License in package.yml. Rebuild to apply changes

Thank you, @algent! ๐Ÿ˜„. Everything should be fine now.

JoshStrobl requested changes to this revision.Thu, Nov 5, 7:56 PM
JoshStrobl added a subscriber: JoshStrobl.

Tested on Budgie and works correctly.

Need a more comprehensive test plan.

Most of the changes referenced at https://github.com/GNOME/pan/blob/master/NEWS can be summarized or omitted as a changelog. Just be sure to omit GitHub issue numbers like #77 and commit hashes. Translations don't need to be noted in the changelog. Should be in Markdown format, with list items using - and no spacing used for level-0 indentation, one space for level-1, etc.

Thanks for taking up maintainership of this!

This revision now requires changes to proceed.Thu, Nov 5, 7:56 PM
abnazhor edited the summary of this revision. (Show Details)Thu, Nov 5, 10:41 PM
abnazhor edited the test plan for this revision. (Show Details)

Fixed, is it okay as it is now? @JoshStrobl

This revision is now accepted and ready to land.Fri, Nov 6, 5:52 AM
This revision was automatically updated to reflect the committed changes.