Page MenuHomeSolus

Python changes in yauto.py script
ClosedPublic

Authored by EP01 on Sep 13 2017, 7:03 PM.
Tags
None
Referenced Files
F11008906: D990.diff
Wed, Aug 2, 7:09 AM
F10974840: D990.id.diff
Sat, Jul 22, 2:30 AM
F10873815: D990.id2285.diff
Jun 19 2023, 6:28 PM
F10873651: D990.id2292.diff
Jun 19 2023, 4:22 PM
F10873110: D990.id2286.diff
Jun 19 2023, 8:00 AM
F10862777: D990.diff
Jun 16 2023, 10:47 PM
F10711613: D990.diff
Apr 30 2023, 2:22 AM
Subscribers

Details

Summary

Moved Python macro to build section to reduce confusion around where it should be.

Test Plan

Generated some Python-based package.yml's.

Diff Detail

Repository
rCOMN common
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

EP01 edited the test plan for this revision. (Show Details)

@JoshStrobl Do you think this would be a good idea to reduce the occurrences of the macros being in the wrong place? (I fixed all mine that you reviewed today, thanks very much for doing that!)

I think the main issue was the name chosen for the macro was just odd, as it kinda builds too ...

Yeah I get that, Josh asked me to change all my new commits to use the Build section for %python_setup, so I thought this would avoid the situation from occurring in the first place.

Fair do, I'll merge then, cheers :)

This revision is now accepted and ready to land.Sep 13 2017, 8:08 PM
This revision was automatically updated to reflect the committed changes.