Page MenuHomeSolus

Update hidapi to v0.10.0
ClosedPublic

Authored by serebit on Oct 28 2020, 6:25 PM.
Tags
None
Referenced Files
F11000250: D9900.diff
Sat, Jul 29, 5:27 AM
F10983637: D9900.diff
Sun, Jul 23, 3:02 PM
F10949784: D9900.id.diff
Sun, Jul 16, 2:57 AM
F10895305: D9900.id23899.diff
Jul 1 2023, 3:55 PM
F10893979: D9900.id23808.diff
Jul 1 2023, 6:44 AM
F10892555: D9900.id23897.diff
Jun 30 2023, 2:11 AM
F10889354: D9900.diff
Jun 27 2023, 9:21 PM
F10844037: D9900.id23808.diff
Jun 10 2023, 7:55 PM
Subscribers

Details

Summary

Summarized Changelog:

  • Add API to get compile/runtime version
  • Add hid_get_input_report function
  • Fix hid_close hanging with some devices on linux/libusb

Full changelog available here.

Test Plan

Compile and run a test program using hidapi

Diff Detail

Repository
R1405 hidapi
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

JoshStrobl added inline comments.
package.yml
14

Why are we compiling this with clang now?

package.yml
14

Well, I tested it to see if it would compile with Clang, and it did. I tested to see if the binary worked, and it did, at around 100 bytes smaller for the eopkg. So I figured, why not? If you'd rather just compile it with GCC, I can remove the line no problem.

JoshStrobl added inline comments.
package.yml
14

100 bytes? That's not a meaningful optimization and can possibly introduce side-effects. If you can show a meaningful performance improvement I could maybe see it, and testing it against gcc + -03.

This revision now requires changes to proceed.Nov 3 2020, 4:13 PM

Build against GCC, not clang

This revision is now accepted and ready to land.Nov 5 2020, 7:53 PM
This revision was automatically updated to reflect the committed changes.