Page MenuHomeSolus

Update buildah to 1.16.5
ClosedPublic

Authored by chax on Oct 23 2020, 1:32 AM.

Details

Summary

Update buildah to 1.16.5

Changelog:

  • copier.copierHandlerPut: don't check length when there are errors
    • When there's an error creating a file as part of an ADD or COPY operation, we now report the error instead of misreporting the error as a size mismatch.
  • bump(github.com/openshift/imagebuilder) to v1.1.8
    • This updates the Dockerfile parser's quoting rules to match the current version of docker build.
  • Run(): ignore containers.conf's environment configuration
    • Don't leak environment configured in containers.conf into builds.
  • ADD and COPY: descend into excluded directories, sometimes
    • Tweak handling of .dockerignore files to include contents inside of excluded directories that should be included as exceptions.
  • Set directory ownership when copied with ID mapping
    • When using non-default ID mappings, correctly set the ownership on leading directories when handling ADD and COPY instructions.
Test Plan

Run a few buildah commands:

  • buildah from debian:buster
  • buildah run debian-working-container apt update
  • buildah run debian-working-container apt upgrade -y
  • buildah run debian-working-container apt install curl -y
  • buildah copy debian-working-container test.sh /local/bin/test.sh
  • buildah run debian-working-container chmod +x /local/bin/test.sh
  • buildah run /local/bin/test.sh
  • buildah config --entrypoint "/local/bin/test.sh" debian-working-container
  • buildah commit debian-working-container debian-test
  • buildah images

Test image with podman:

  • podman run debian-test
  • podman run -it debian-test /bin/bash

Diff Detail

Repository
R4789 buildah
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chax created this revision.Oct 23 2020, 1:32 AM
chax requested review of this revision.Oct 23 2020, 1:32 AM
JoshStrobl accepted this revision.Oct 23 2020, 9:35 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Oct 23 2020, 9:35 AM
This revision was automatically updated to reflect the committed changes.