Page MenuHomeSolus

Some fixes for pysolfc-cardsets
ClosedPublic

Authored by algent on Oct 22 2020, 11:47 AM.

Details

Summary

Packager notes:

  • Add homepage
  • Fix license
  • Remove COPYRIGHT files

Signed-off-by: Algent Albrahimi <algent@protonmail.com>

Test Plan

Run a few games with pysolfc and aisleriot and change cardsets.

Diff Detail

Repository
R2523 pysolfc-cardsets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

algent created this revision.Oct 22 2020, 11:47 AM
algent requested review of this revision.Oct 22 2020, 11:47 AM
algent updated this revision to Diff 23744.Oct 22 2020, 11:53 AM

Fix package.yml

JoshStrobl requested changes to this revision.Oct 22 2020, 3:04 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
This revision now requires changes to proceed.Oct 22 2020, 3:04 PM
algent added inline comments.Oct 22 2020, 3:49 PM
package.yml
7

That is for pysolfc, but I checked every COPYRIGHT file in $installdir/usr/share/PySolFC/*/COPYRIGHT they were all GPL-2.0-or-later

JoshStrobl added inline comments.Oct 22 2020, 4:01 PM
package.yml
7

It's shipped in the pysolfc repo as well, which has the license of GPL-3.0-or-later. So either we should list both of them, or GPL-3.0-or-later, since IMO that supercedes 2.0 given 3.0 is later than 2.0.

algent updated this revision to Diff 23753.Oct 22 2020, 4:05 PM

Use GPL-3.0-or-later license

JoshStrobl added inline comments.Oct 23 2020, 9:38 AM
package.yml
15–16

You added a whitespace at the end of this line

algent updated this revision to Diff 23765.EditedOct 23 2020, 9:48 AM

Remove extra whitespace.

algent marked 3 inline comments as done.Oct 23 2020, 9:49 AM
algent added inline comments.
package.yml
15–16

Done

JoshStrobl accepted this revision.Oct 23 2020, 9:57 AM

Thanks :) Looks good to me.

This revision is now accepted and ready to land.Oct 23 2020, 9:57 AM
This revision was automatically updated to reflect the committed changes.