Page MenuHomeSolus

Update nim to 1.4.0
ClosedPublic

Authored by akrenz on Oct 20 2020, 9:22 PM.

Details

Summary

Too many changes, without some being really outstanding/major changes, to give a short Summary. The complete Changelog can be found at: https://github.com/nim-lang/Nim/blob/devel/changelogs/changelog_1_4_0.md

Test Plan

Compile and run example programms from https://nim-lang.org/. Create and build new package via nimble. Verified bash autocompletion shows nimble commands

Diff Detail

Repository
R2167 nim
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

akrenz created this revision.Oct 20 2020, 9:22 PM
akrenz requested review of this revision.Oct 20 2020, 9:22 PM
akrenz updated this revision to Diff 23711.Oct 20 2020, 9:36 PM

Fix Author error inside pspec file.

JoshStrobl requested changes to this revision.Oct 21 2020, 11:04 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
files/0001-Change-to-correct-dirs.patch
1 ↗(On Diff #23711)

Why was all of this removed? This is a git format patch...

This revision now requires changes to proceed.Oct 21 2020, 11:04 AM
akrenz updated this revision to Diff 23771.Oct 23 2020, 7:43 PM

Restored patch file

akrenz marked an inline comment as done.Oct 23 2020, 7:44 PM
akrenz added inline comments.
files/0001-Change-to-correct-dirs.patch
1 ↗(On Diff #23711)

Tried something out and comited this change by error. Sorry about that.

JoshStrobl requested changes to this revision.Oct 26 2020, 3:49 PM

There doesn't seem to be any actual changes to my patch, so not sure what the change is all about. Original file should be restored, rebuilt, commit amended and diff updated. Otherwise LGTM.

This revision now requires changes to proceed.Oct 26 2020, 3:49 PM
akrenz updated this revision to Diff 23841.Fri, Oct 30, 7:45 PM
akrenz marked an inline comment as done.

Restored original patch from Josh Strobl

JoshStrobl accepted this revision.Tue, Nov 3, 6:12 PM

LGTM, thanks!

This revision is now accepted and ready to land.Tue, Nov 3, 6:12 PM
This revision was automatically updated to reflect the committed changes.