Signed-off-by: Régis Patroix <regis.patroix@gmail.com>
Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Commits
- R2150:a75c25f419ba: Update Netdata to 1.26.0
- Access http://127.0.0.1:19999 and watch metrics
Diff Detail
Diff Detail
- Repository
- R2150 netdata
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Good start though.
| files/netdata.tmpfiles | ||
|---|---|---|
| 5 | I'd prefer we just patch out the check entirely and always have it disabled: function starts at https://github.com/netdata/netdata/blob/master/daemon/main.c#L837 | |
| package.yml | ||
| 5–6 | Should be updated to SPDX 3 spec | |
| 9–10 | Should have description not use 80 column. Can have it wrap normally. | |
| 15 | Use the pkgconfig. | |
| 18 | We have the reconfigure macro that does this, but it shouldn't be necessary to begin with. Their dist tarball ships with a configure already generated. | |
Comment Actions
- Switch to SPDX 3 spec license
- Use pkgconfig for libuv
- Disable anonymous statistics
- Reconfigure not needed
- Description not use 80 column
| files/01-disable.patch | ||
|---|---|---|
| 10 ↗ | (On Diff #23852) | Why are you disabling these statistics? We aren't anti-statistics / telemetry, especially when they're anonymous. |