Page MenuHomeSolus

The inclusion of fuse-zip fixes T9319
ClosedPublic

Authored by liontiger23 on Sun, Oct 11, 5:23 PM.

Details

Summary

Initial inclusion of fuse-zip

Resolves T9319

Test Plan

Tested using vifm: opened and browsed some .zip archives

Diff Detail

Repository
R5084 fuse-zip
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

liontiger23 created this revision.Sun, Oct 11, 5:23 PM
liontiger23 requested review of this revision.Sun, Oct 11, 5:23 PM
liontiger23 edited the summary of this revision. (Show Details)Sun, Oct 11, 5:27 PM
JoshStrobl requested changes to this revision.Tue, Oct 13, 4:28 PM
JoshStrobl added a subscriber: JoshStrobl.

Also need to include a MAINTAINERS.md file, containing the following contents, replacing content where applicable:

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- REPLACEME FIRST NAME(S) LAST NAME(S)
  - IRC: REPLACEME
  - Email: REPLACEME
pspec_x86_64.xml
23

You should be installing into /usr not /usr/local

This revision now requires changes to proceed.Tue, Oct 13, 4:28 PM

Add MAINTAINERS.md and fix prefix

liontiger23 marked an inline comment as done.Wed, Oct 14, 3:03 AM
Unknown Object (User) added a subscriber: Unknown Object (User).Wed, Oct 14, 11:23 AM
This comment was removed by JoshStrobl.
JoshStrobl requested changes to this revision.Thu, Oct 15, 3:54 AM
JoshStrobl added inline comments.
package.yml
16

Honestly we're not planning on changing our prefix so it's safe to just do /usr instead.

pspec_x86_64.xml
25

May as well nuke /usr/share/doc, we don't need to ship the readme or the changelog.

This revision now requires changes to proceed.Thu, Oct 15, 3:54 AM

Use explicit prefix and nuke docs

liontiger23 marked 2 inline comments as done.Thu, Oct 15, 4:44 AM
JoshStrobl accepted this revision.Thu, Oct 15, 5:42 AM

LGTM, thanks!

Macro perfection:

This revision is now accepted and ready to land.Thu, Oct 15, 5:42 AM
This revision was automatically updated to reflect the committed changes.