Page MenuHomeSolus

Inclusion of protonmail-bridge fixes T8937
AbandonedPublic

Authored by JeffLabonte on Oct 11 2020, 1:33 AM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Test Plan

Installed and tested it with Geary

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

JeffLabonte created this revision.Oct 11 2020, 1:33 AM
JeffLabonte requested review of this revision.Oct 11 2020, 1:33 AM
DataDrake requested changes to this revision.Dec 16 2020, 7:49 AM
DataDrake added a subscriber: DataDrake.

A lot of work to do here. So far this looks like a copy-pasta from Arch and it shows in the final result. Even though it's a derivative work, we treat this as plagiarism and ask that you not do this, especially without any sort of attribution. Please take the time to address all of the inline comments, as well as ensuring that you understand everything that is being done.

package.yml
5

So, I don't really see a reason to use the git support when they aren't actually using Git submodules. You should be using versioned tarballs instead. And given that they seem to be tagging the bridge and the GUI separately after the 1.3 series, they'll need to be two separate packages.

8

lower-case true

12

Should be using pkgconfigs where possible: pkgconfig(libsecret-1)

Same goes for the Qt deps. You can see these in the Provides section of eopkg info when looking at the -devel package.

20

You can use install -d without specifying access permissions because all directories are 00755 by default on Linux.

22

This isn't needed since -D takes care of it. You only need to create directories that you are copying or symlinking into.

25

If you are copying, you need to go back and make sure the permissions are set to read-only, with execute where needed.

29

Seems like this should just be proton-bridge without the .git. Though I'm guessing if you were building against the system Qt5, you could just install the binary to /usr/bin and forego /usr/lib64/protonmail-bridge altogether.

30

SVG icon should be named protonmail-bridge.svg and go in: /usr/share/icons/hicolor/scalable/apps/
Which means the .desktop file needs fixing to just ask for protonmail-bridge as the icon.

31

We don't copy licenses unless the build system does it automatically. It's already documented in the metadata.

pspec_x86_64.xml
16

Guessing you didn't rebuild after fixing these.

22

This needs to be using the system Qt5, vendoring is not acceptable.

This revision now requires changes to proceed.Dec 16 2020, 7:49 AM
JoshStrobl abandoned this revision.Jan 20 2021, 5:04 PM