Page MenuHomeSolus

Update rust to 1.47.0
ClosedPublic

Authored by livingsilver94 on Oct 10 2020, 10:19 PM.

Details

Summary

Changelog available here.

Test Plan

Built bat. Firefox rebuild pending.

Diff Detail

Repository
R2839 rust
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 requested review of this revision.Oct 10 2020, 10:19 PM
JoshStrobl requested changes to this revision.Oct 13 2020, 4:09 PM
JoshStrobl added a subscriber: JoshStrobl.

Seeing as neither thunderbird or firefox build according to discussions in IRC, those either need to be patched or this just closed.

This revision now requires changes to proceed.Oct 13 2020, 4:09 PM

Nah it's a regression of Rust. I'm waiting for a possible v1.47.1 before closing this patch.

Nah it's a regression of Rust. I'm waiting for a possible v1.47.1 before closing this patch.

They're not considering it a regression and in theory it should be something that's fixed in Thunderbird 78.4 compilation. Given the proximity of sync at the moment, not going to be pushing Thunderbird 78.4, so that's something that can be tested post-sync if you happen to still have the rust eopkgs.

New thunderbird has been pushed, may be worth testing if you can build it against 1.47.0 without having to patch it.

I doubt that, but yeah I'm trying tomorrow.

livingsilver94 requested review of this revision.Nov 1 2020, 4:26 PM
This revision is now accepted and ready to land.Nov 3 2020, 6:15 PM
This revision was automatically updated to reflect the committed changes.