Page MenuHomeSolus
Differential D9758

Initial packaging of libfido2 1.5.0
ClosedPublic
Actions

Authored by silke on Sep 30 2020, 5:05 PM.
Tags
None
Referenced Files
F11069145: D9758.id23513.diff
Fri, Aug 11, 10:31 PM
F11050958: D9758.diff
Thu, Aug 10, 7:38 PM
F10958353: D9758.id23506.diff
Tue, Jul 18, 12:13 AM
F10944050: D9758.diff
Fri, Jul 14, 10:02 PM
F10935963: D9758.id23511.diff
Thu, Jul 13, 12:24 AM
F10911596: D9758.id23513.diff
Jul 7 2023, 9:30 AM
F10908599: D9758.diff
Jul 7 2023, 12:48 AM
F10895400: D9758.id23502.diff
Jul 1 2023, 4:26 PM
View All 15 Files
Subscribers
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R5082:44306debbbc4: Initial packaging of libfido2 1.5.0
Summary

Initial packaging of libfido2 as a dependency for FIDO2 support in OpenSSH.

Depends on D9757

Test Plan
  • Tested as part of OpenSSH
  • Compile and run two example programs

Diff Detail

Repository
R5082 libfido2
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

silke created this revision.Sep 30 2020, 5:05 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptSep 30 2020, 5:05 PM
silke requested review of this revision.Sep 30 2020, 5:05 PM
silke added a child revision: D9759: Enable FIDO2 support in OpenSSH.Sep 30 2020, 5:12 PM
silke mentioned this in D9757: Initial packaging of libcbor 0.8.0.Sep 30 2020, 5:15 PM
JoshStrobl requested changes to this revision.Sep 30 2020, 5:37 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
pspec_x86_64.xml
238

Static should be disabled.

This revision now requires changes to proceed.Sep 30 2020, 5:37 PM
silke updated this revision to Diff 23506.Sep 30 2020, 6:12 PM
  • Remove static library
  • Move man(3) pages to devel
JoshStrobl requested changes to this revision.Sep 30 2020, 6:32 PM
JoshStrobl added inline comments.
package.yml
26

I'd prefer if we patched out static so we're not wasting time building it: https://github.com/Yubico/libfido2/blob/master/src/CMakeLists.txt#L68

This revision now requires changes to proceed.Sep 30 2020, 6:32 PM
silke updated this revision to Diff 23511.Sep 30 2020, 6:46 PM
silke marked an inline comment as done.

Add patch to disable building static library and examples

JoshStrobl accepted this revision.Sep 30 2020, 6:49 PM

Much better, thank you!

This revision is now accepted and ready to land.Sep 30 2020, 6:49 PM
JoshStrobl mentioned this in R5081:f71c0c3bfb0e: Initial packaging of libcbor 0.8.0.Sep 30 2020, 6:49 PM
Closed by commit R5082:44306debbbc4: Initial packaging of libfido2 1.5.0 (authored by silke, committed by JoshStrobl). · Explain WhySep 30 2020, 6:53 PM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R5082:44306debbbc4: Initial packaging of libfido2 1.5.0.

Revision Contents
Changeset List

Diff 23513

View Options

MAINTAINERS.md

Loading...
View Options

Makefile

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

files/0001-Remove-building-of-static-library-and-examples.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.