Page MenuHomeSolus

Initial packaging of libfido2 1.5.0
ClosedPublic

Authored by silke on Wed, Sep 30, 5:05 PM.

Details

Summary

Initial packaging of libfido2 as a dependency for FIDO2 support in OpenSSH.

Depends on D9757

Test Plan
  • Tested as part of OpenSSH
  • Compile and run two example programs

Diff Detail

Repository
R5082 libfido2
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

silke created this revision.Wed, Sep 30, 5:05 PM
silke requested review of this revision.Wed, Sep 30, 5:05 PM
JoshStrobl requested changes to this revision.Wed, Sep 30, 5:37 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
pspec_x86_64.xml
238

Static should be disabled.

This revision now requires changes to proceed.Wed, Sep 30, 5:37 PM
silke updated this revision to Diff 23506.Wed, Sep 30, 6:12 PM
  • Remove static library
  • Move man(3) pages to devel
JoshStrobl requested changes to this revision.Wed, Sep 30, 6:32 PM
JoshStrobl added inline comments.
package.yml
26

I'd prefer if we patched out static so we're not wasting time building it: https://github.com/Yubico/libfido2/blob/master/src/CMakeLists.txt#L68

This revision now requires changes to proceed.Wed, Sep 30, 6:32 PM
silke updated this revision to Diff 23511.Wed, Sep 30, 6:46 PM
silke marked an inline comment as done.

Add patch to disable building static library and examples

JoshStrobl accepted this revision.Wed, Sep 30, 6:49 PM

Much better, thank you!

This revision is now accepted and ready to land.Wed, Sep 30, 6:49 PM
This revision was automatically updated to reflect the committed changes.