Page MenuHomeSolus
Differential D9746

Initial commit of nlohmann-json
ClosedPublic
Actions

Authored by aleksvor on Sep 29 2020, 7:40 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R5079:950bbddb7b53: Initial commit of nlohmann-json
Summary

Initial commit of nlohmann-json - new dependency of OpenRCT2 0.3.1.

Test Plan

Built openrct2 0.3.1 against it.

Diff Detail

Repository
R5079 nlohmann-json
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aleksvor created this revision.Sep 29 2020, 7:40 AM
aleksvor requested review of this revision.Sep 29 2020, 7:40 AM
livingsilver94 added a subscriber: livingsilver94.Sep 29 2020, 8:26 AM
livingsilver94 added inline comments.
package.yml
14

Doesn't split: no achieve the same result?

aleksvor added inline comments.Sep 29 2020, 4:54 PM
package.yml
14

No, with this key solbuild places all files in devel package.

JoshStrobl accepted this revision.Sep 29 2020, 8:43 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Sep 29 2020, 8:43 PM
Closed by commit R5079:950bbddb7b53: Initial commit of nlohmann-json (authored by aleksvor, committed by JoshStrobl). · Explain WhySep 29 2020, 8:44 PM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R5079:950bbddb7b53: Initial commit of nlohmann-json.

Revision Contents
Changeset List

PathPackages
AMMakefile (1 line)
AMpackage.yml (19 lines)
AMpspec_x86_64.xml (39 lines)

Diff 23483

View Options

Makefile

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.