Page MenuHomeSolus

Update twolame to 0.4.0
ClosedPublic

Authored by YakoYakoYokuYoku on Mon, Sep 28, 10:51 PM.

Details

Summary

Changelog:

  • Added free format encoding (now up to 450 kbps).
  • Added DAB utility methods for ScF-CRC handling.
  • Added twolame_get_original() and twolame_set_original().
  • Added twolame_get_extension() and twolame_set_extension().
  • Make libsndfile dependency (and therefore the frontend) optional.
  • Fixed VBR encoding.
  • Fixed setting for error protection flag.
  • New check for invalid bitrate/channel encoder settings.
  • New checks against failed memory allocations.
  • Fixed padding policy (now adding an empty slot).
  • Fixed scaling of floating point input source through libsndfile.
  • Removed slotinfo global variables to fix thread safety bug.
  • Switched to handling reading from STDIN using libsndfile.
  • Fix for potential buffer overrun relating to MAX_NAME_SIZE in CLI tool.
  • Zero the whole of the data structure when calling twolame_init().
  • Prefixed all global symbols with twolame_ to prevent symbol conflicts.
  • Fix for twolame_get_framelength() returning the correct frame size when padding is enabled.
  • Fix progress counter in twolame CLI.
  • Compiler and Valgrind warning fixes.
  • Various other minor fixes.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Encoded a WAV file with twolame -V -5.0 test.wav, another FLAC file with ffmpeg -i test.flac test.mp2 and built all the revdeps against it.

Diff Detail

Repository
R3069 twolame
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Mon, Sep 28, 10:51 PM
JoshStrobl requested changes to this revision.Tue, Sep 29, 8:40 PM
JoshStrobl added a subscriber: JoshStrobl.

Needs more comprehensive testing and rebuilds against ffmpeg, gstreamer-1.0-plugins-good, audacity, avidemux, and vlc.

This revision now requires changes to proceed.Tue, Sep 29, 8:40 PM
YakoYakoYokuYoku edited the test plan for this revision. (Show Details)

Done more testing

JoshStrobl accepted this revision.Tue, Oct 6, 4:39 PM

LGTM, thanks!

This revision is now accepted and ready to land.Tue, Oct 6, 4:39 PM
This revision was automatically updated to reflect the committed changes.