Page MenuHomeSolus

libreoffice: enable full KF5 integration
ClosedPublic

Authored by livingsilver94 on Sep 26 2020, 11:27 AM.

Details

Summary

full KF5 integration seems to play nice with dark themes now, so let's ship it.
Also, the perceived LibreOffice startup time is shorter in Plasma.

Test Plan

Browsed some LibreOffice Writer menus and buttons without glitches.

Diff Detail

Repository
R1835 libreoffice
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 requested review of this revision.Sep 26 2020, 11:27 AM
livingsilver94 added inline comments.
package.yml
313

@kyrios123 out of curiosity, why this?

JoshStrobl added inline comments.
package.yml
313

Not really sure why you're pinging Kyrios, Ikey was the one that originally disable LTO because it resulted in broken builds. See https://dev.getsol.us/R1835:9b8e14fe792c56ce8bd345aa53ca8839c24f20f0

Either way, unless you can provide benchmarks that indicate there is a substantial increase in performance outside margin of error and zero breakages, it isn't going to get enabled. The choice to enable or disable LTO isn't just related to whether or not something is faster (or in this case, it was because it was broken), but whether something is fast(er) enough to warrant a potentially substantial increase in build time, which both reduces the likelihood of the package being updated on a reasonable cadence as well as not blocking other items.

livingsilver94 added inline comments.Sep 29 2020, 7:30 PM
package.yml
313

Because he's the maintainer.

Anyway, if -disable-lto has to be passed, probably the LO devs concluded that LTO benefits the suite. Also, I personally don't care about the performance of an office suite, but I do care for its size, that LTO usually reduces. These were my thoughts when I asked that question.

My doubt is cleared.

livingsilver94 added a comment.EditedOct 8 2020, 6:52 PM

LO 7.0.2 is out. Please accept my patch before it gets updated, I don't want to rebuild it >.<

JoshStrobl accepted this revision.Oct 8 2020, 7:57 PM
JoshStrobl added a subscriber: Girtablulu.

LGTM but relying on you, @Girtablulu and other Plasma users to test it on Plasma before sync :)

This revision is now accepted and ready to land.Oct 8 2020, 7:57 PM
This revision was automatically updated to reflect the committed changes.