Page MenuHomeSolus

Initial commit of haskell-Diff
ClosedPublic

Authored by xulongwu4 on Sep 25 2020, 2:28 AM.

Details

Summary

Initial commit of haskell-Diff.

Test Plan

Dependency of D9715.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

xulongwu4 created this revision.Sep 25 2020, 2:28 AM
xulongwu4 requested review of this revision.Sep 25 2020, 2:28 AM
xulongwu4 updated this revision to Diff 23399.Sep 25 2020, 2:41 AM

Rename package to haskell-Diff

xulongwu4 retitled this revision from Initial commit of haskell-diff to Initial commit of haskell-Diff.Sep 25 2020, 2:41 AM
xulongwu4 edited the summary of this revision. (Show Details)
DataDrake accepted this revision.Dec 16 2020, 8:12 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Dec 16 2020, 8:12 AM

Do we really want the uppercase D? Not even Perl packages have uppercase letters in their name.

This revision was automatically updated to reflect the committed changes.

Do we really want the uppercase D? Not even Perl packages have uppercase letters in their name.

This is the standard Bryan wants to have for Haskell packages. It's not a global naming standard. So yes he's sure.

Do we really want the uppercase D? Not even Perl packages have uppercase letters in their name.

If this case absolutely because "Diff" and "diff" are two different libraries in Haskell.