Page MenuHomeSolus

msmtp: Update to latest release 1.8.15
ClosedPublic

Authored by palto42 on Sep 20 2020, 4:49 PM.

Details

Summary

This update fixes T9287.

Changelog available here from 1.6.6 to 1.8.15

Signed-off-by: Matthias Homann <palto@mailbox.org>

Test Plan

Build, installed and tested on one device. Fixed the TLS error reported in T9287

Diff Detail

Repository
R2110 msmtp
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

palto42 created this revision.Sep 20 2020, 4:49 PM
palto42 requested review of this revision.Sep 20 2020, 4:49 PM
palto42 updated this revision to Diff 23381.Sep 22 2020, 6:25 PM

Corrected packager email address.

livingsilver94 added a subscriber: livingsilver94.EditedSep 28 2020, 7:04 PM

@palto42 could you please add Fixes T9287 in the Summary? So that this patch gets automatically associated to the task you're solving.

palto42 updated this revision to Diff 23457.Sep 28 2020, 7:59 PM
palto42 retitled this revision from msmtp: Update to lates release 1.8.12 This update fixes T9287 to msmtp: Update to lates release 1.8.12.
palto42 edited the summary of this revision. (Show Details)

Added reference to T9287 in the Summary

@livingsilver94 Hope the format is ok now, I'm new to Arcanist and was not sure about the formatting of the commit message.

Should be OK now! There's just a small typo you can fix ("lates"), and you didn't provide a changelog. Given how many versions have been skipped, I think it's safe to just add Changelog available [here](https://marlam.de/msmtp/news/) from X to Y. in the Summary.

There's not an enforced format by the way, only some common templates.

palto42 updated this revision to Diff 23490.Sep 30 2020, 6:15 AM
palto42 retitled this revision from msmtp: Update to lates release 1.8.12 to msmtp: Update to latest release 1.8.12.
palto42 edited the summary of this revision. (Show Details)

Added link to changelog and fixed typo.

DataDrake requested changes to this revision.Dec 16 2020, 8:52 AM
DataDrake added a subscriber: DataDrake.

See inline comments.

package.yml
12

We don't do multi-line descriptions unless it's really needed. I think the summary text is fine in this case, but you are welcome to write a 2-3 sentence description as long as it's concise and readable.

This revision now requires changes to proceed.Dec 16 2020, 8:52 AM
palto42 updated this revision to Diff 24606.Dec 27 2020, 1:15 PM

Shortened descriprion as requested by the reviewer.

palto42 updated this revision to Diff 24607.Dec 27 2020, 3:20 PM
palto42 marked an inline comment as done.

Updating to latest release 1.8.14

palto42 retitled this revision from msmtp: Update to latest release 1.8.12 to msmtp: Update to latest release 1.8.14.Dec 27 2020, 3:20 PM
palto42 edited the summary of this revision. (Show Details)
palto42 added inline comments.Jan 10 2021, 6:43 PM
package.yml
12

Hope this shorter description is ok.

JoshStrobl requested changes to this revision.Jan 21 2021, 4:34 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
12

It's better but still doesn't need to be multi-line.

This revision now requires changes to proceed.Jan 21 2021, 4:34 AM
palto42 updated this revision to Diff 25128.Jan 23 2021, 11:00 AM

Shortened description to single line as requested by reviewer.

palto42 edited the summary of this revision. (Show Details)Jan 23 2021, 11:02 AM
palto42 marked an inline comment as done.Jan 26 2021, 8:55 PM

Sorry, was not clear that single line is quite strict rule.

Is there anything missing to get this merged?

palto42 updated this revision to Diff 25747.Mar 13 2021, 9:32 AM

Update to version 1.8.15, see https://marlam.de/msmtp/news/

palto42 retitled this revision from msmtp: Update to latest release 1.8.14 to msmtp: Update to latest release 1.8.15.Mar 13 2021, 9:32 AM
palto42 edited the summary of this revision. (Show Details)

@JoshStrobl Sorry to say, but I'm getting a bit frustrated to wait that long for a quite simple update to get merged. Just wanted to help and contribute to the Solus project, but I get the feeling that my help is not much appreciated.
It also makes me worry to see packages in the repository without any updates since years, which could cause potential security risks (not in this case, but maybe for other packages).

This comment was removed by JoshStrobl.
JoshStrobl accepted this revision.Mar 28 2021, 4:36 PM

Will merge this when I have the time.

You know...seeing as I am a volunteer. Nice to know you value my time too.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 28 2021, 6:54 PM
This revision was automatically updated to reflect the committed changes.