Page MenuHomeSolus

Update libicu to 59.1
ClosedPublic

Authored by joebonrichie on Sep 8 2017, 5:07 PM.

Details

Summary

Release notes available here

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan
  • build & test harfbuzz against this library

Diff Detail

Repository
R1734 libicu
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kyrios123 created this revision.Sep 8 2017, 5:07 PM
ikey added inline comments.
package.yml
17

What's this for?

kyrios123 added inline comments.Sep 9 2017, 1:26 PM
package.yml
17

This is because xlocale.h has been removed from glibc 2.26.
It will prevent useless problems: https://sourceware.org/glibc/wiki/Release/2.26#Removal_of_.27xlocale.h.27

ikey added inline comments.Sep 9 2017, 1:30 PM
package.yml
17

But we don't have glibc 2.27

kyrios123 added inline comments.Sep 9 2017, 1:37 PM
package.yml
17

I know we still have 2.25 but it will prevent problems when glibc will be updated to 2.26 or above.

Since they said it's a nonstandard header and it was never intended to be included directly by programs other than glibc itself, I don't see any reason for not "fixing" it. Of course I can remove this line if you prefer, you're the boss ! ?

Added chromium as a child dep of this as it bundles icu 59.1, but ideally I'd like chromium to use the system library.

Been working on the rebuilds locally, everything seems okay. Will get this in after friday sync

joebonrichie commandeered this revision.Oct 27 2017, 8:34 PM
joebonrichie added a reviewer: kyrios123.

Remove unnecesary change for glibc

This revision was automatically updated to reflect the committed changes.