Page MenuHomeSolus

Update libsndfile to 1.0.30
ClosedPublic

Authored by Jacalz on Sep 20 2020, 9:39 AM.

Details

Summary

Summarized Changelog:

  • Fixes for multiple security issues (most of which we already had backported).
  • Add support for Opus files.
  • Add BWF v2 loudness parameters.
  • Wave64: Permit and skip arbitrary chunks prior to the data chunk.
  • Fix ASAN crash in wavlike_ima_seek().
  • Fix IMA-ADPCM encoding for AIFF files.
  • sndfile-convert: Handle gsm, vox and opus extensions the same way.
  • Add SFC_SET_OGG_PAGE_LATENCY_MS command to get Ogg page latency for Ogg Opus files.
  • Fix parsing of some SD2 files.
  • Fix memory leak in wavlike_read_bext_chunk() function, credit to OSS-Fuzz.
  • Fix undefined behavior in avr-read_header() function, credit to OSS-Fuzz.
  • Fix infinite loops on some pathological SD2 files.
  • Fix bug when sf_open_fd() function sometimes leaves filehandle open, even if close_desc parameter is TRUE.
  • Minor bug fixes and improvements.
Test Plan
  • Load up Ardour and create a little song with multiple LV2 plugins.

Diff Detail

Repository
R1850 libsndfile
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacalz created this revision.Sep 20 2020, 9:39 AM
Jacalz requested review of this revision.Sep 20 2020, 9:39 AM
aleksvor added inline comments.
abi_used_libs
5–8

You need to add dependency on opus to get external libraries back - apparently they require all external libraries to be present to build against them, in other case they force internal sources.

Jacalz updated this revision to Diff 23350.Sep 20 2020, 11:17 AM

Build with opus (thanks @aleksvor)

JoshStrobl requested changes to this revision.Sep 22 2020, 1:29 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
5
20

Can be removed, use rel tarball + configure

This revision now requires changes to proceed.Sep 22 2020, 1:29 PM
Jacalz added inline comments.Sep 22 2020, 5:40 PM
package.yml
5

Sorry that isn't working as it should. Tests (or checks) are constantly failing when building using that one :(

Jacalz requested review of this revision.Sep 23 2020, 1:09 PM

Sorry @JoshStrobl. I can't use the release tarballs on GitHub because the checks are failing for some reason when using those. Would you mind re-reviewing?

JoshStrobl accepted this revision.Sep 23 2020, 2:44 PM

LGTM, thanks for the response!

This revision is now accepted and ready to land.Sep 23 2020, 2:44 PM
This revision was automatically updated to reflect the committed changes.