Page MenuHomeSolus

initial inclusion of github-cli
ClosedPublic

Authored by sethfl on Sep 19 2020, 11:11 PM.

Details

Summary

Initial inclusion of github-cli.

Resolves T9285

Test Plan
  • Login to GitHub account
  • Create a new repository
  • Clone a repository
  • Open a PR
  • Submit an issue
  • Create a gist

Diff Detail

Repository
R5076 github-cli
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sethfl created this revision.Sep 19 2020, 11:11 PM
sethfl requested review of this revision.Sep 19 2020, 11:11 PM
JoshStrobl requested changes to this revision.Sep 22 2020, 1:21 PM
JoshStrobl added a subscriber: JoshStrobl.

Otherwise LGTM. Shame they don't have a proper install target.

package.yml
18

This is part of system.base. It isn't needed, it will always be installed on a system.

This revision now requires changes to proceed.Sep 22 2020, 1:21 PM
sethfl updated this revision to Diff 23382.Sep 23 2020, 3:52 AM

remove unneeded rundep

sethfl marked an inline comment as done.Sep 23 2020, 3:52 AM
sethfl updated this revision to Diff 23383.Sep 23 2020, 3:58 AM

restore build files

Jacek added a subscriber: Jacek.Sep 23 2020, 8:45 PM
JoshStrobl accepted this revision.Sep 23 2020, 11:24 PM

LGTM, thanks!

This revision is now accepted and ready to land.Sep 23 2020, 11:24 PM
This revision was automatically updated to reflect the committed changes.