Details

Reviewers

Group Reviewers

Commits

R4120:0ebe19dc259e: Update ldc to 1.23.0 and rebuild for LLVM 10

Summary

Rebuilt for LLVM 10 and rebootstrapped. Full release notes for each version between 1.20.1 and 1.23.0 are available here.

Test Plan

Rebuild dub, tilix, and gtkd

Diff Detail

Repository

R4120 ldc

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

serebit created this revision.Sep 19 2020, 5:31 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 19 2020, 5:31 PM

serebit requested review of this revision.Sep 19 2020, 5:31 PM

serebit edited the summary of this revision. (Show Details)Sep 19 2020, 5:31 PM

serebit added a parent revision: D9679: Update LLVM to 10.0.1. Resolves T8843.

Remove unused patch

Fix licenses

serebit retitled this revision from Update ldc to 1.23.0 to Update ldc to 1.23.0 and rebuild for LLVM 10.Sep 20 2020, 3:30 AM

I'm not seeing gtkd and tilix in the test plan. They're rev deps.

package.yml
10–11	Should be above the BSD license.

This revision now requires changes to proceed.Sep 22 2020, 2:03 PM

Move apache-2.0 license entry

JoshStrobl requested changes to this revision.Sep 22 2020, 2:28 PM

JoshStrobl added inline comments.

files/dont-force-gold.patch
8	They changed the code here, we shouldn't be forcing gold as the linker preference, keep to bfd https://github.com/ldc-developers/ldc/blob/master/driver/linker-gcc.cpp#L573 Really the `ArgsBuilder::addLinker` function can just do the previous push_back call.
18	We need to re-remove this. They still have it. https://github.com/ldc-developers/ldc/blob/master/CMakeLists.txt#L445

This revision now requires changes to proceed.Sep 22 2020, 2:28 PM

serebit marked an inline comment as done.Sep 22 2020, 2:38 PM

Working on this. Having issues building gtkd with new LDC, need time to look into it. Will hopefully be done by today.

Rebuilt gtkd, required changes. If Tilix succeeds I'll push the gtkd diff and update this, and it should be good to go.

Apply requested changes (don't force gold, don't use LTO/PGO)

serebit added a child revision: D9709: Rebuild gtkd for ldc update.Sep 22 2020, 3:03 PM

serebit edited the test plan for this revision. (Show Details)

LGTM, thanks!

This revision is now accepted and ready to land.Sep 23 2020, 11:25 PM

Closed by commit R4120:0ebe19dc259e: Update ldc to 1.23.0 and rebuild for LLVM 10 (authored by serebit, committed by JoshStrobl). · Explain WhySep 28 2020, 4:51 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R4120:0ebe19dc259e: Update ldc to 1.23.0 and rebuild for LLVM 10.

serebit marked 2 inline comments as done.Sep 28 2020, 5:53 PM

		Path
M		abi_symbols (18013 lines)
M		abi_used_libs (3 lines)
A	M	files/0001-dont-use-lto-and-or-pgo.patch (28 lines)
A	M	files/0001-use-bfd-instead-of-gold.patch (25 lines)
D	M	files/dont-force-gold.patch (21 lines)
M		package.yml (25 lines)
M		pspec_x86_64.xml (53 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23331	52cf194		Sep 19 2020, 5:31 PM	★	★
Diff 2	23332	52cf194	Remove unused patch	Sep 19 2020, 5:32 PM	★	★
Diff 3	23341	52cf194	Fix licenses	Sep 19 2020, 8:16 PM	★	★
Diff 4	23375	52cf194	Move apache-2.0 license entry	Sep 22 2020, 2:14 PM	★	★
Diff 5	23380	52cf194	Apply requested changes (don't force gold, don't use LTO/PGO)	Sep 22 2020, 3:02 PM	★	★
Diff 6	23452	52cf194	R4120:0ebe19dc259e69d10a37660aa757e92cca7bfc35	Sep 28 2020, 4:51 PM	★	★

Status	Author	Revision
Closed	Girtablulu	D8528 Update graph-tool to 2.32 and rebuild for cgal and libboost
Abandoned	algent	D8653 Rebuild eiskaltdcpp against libboost 1.72.0
Closed	aleksvor	D8680 Rebuild innoextract against libboost 1.72
Abandoned	livingsilver94	D8970 Update mongodb to 4.2.7
Closed	YakoYakoYokuYoku	D8975 Update mongodb to 4.2.8
Closed	YakoYakoYokuYoku	D8974 Update wiredtiger to 3.3.0
Closed	livingsilver94	D8971 Update python-cheetah to 3.2.5
Closed	YakoYakoYokuYoku	D9051 Update scons to 3.1.2
Closed	akrenz	D9012 Rebuild rstudio against libboost 1.72
Abandoned	padraig	D9381 Update graph-tool to 2.33 and fix T9215
Closed	serebit	D9690 Update python-numba to 0.51.2 and rebuild for LLVM 10
Closed	serebit	D9689 Update python-llvmlite to 0.34.0 and rebuild for LLVM 10
Closed	serebit	D9680 Rebuild Blender for LLVM 10
Closed	serebit	D9683 Rebuild dolphin-emu for LLVM 10
Closed	serebit	D9684 Rebuild mesalib for LLVM 10
Closed	serebit	D9685 Update lldb to 10.0.1
Closed	serebit	D9686 Patch beignet for LLVM 10
Closed	serebit	D9687 Rebuild qt-creator for LLVM 10
Closed	serebit	D9688 Rebuild rust for LLVM 10
Closed	padraig	D9382 Update graph-tool to 2.35 and fix T9215
Closed	kyrios123	D8527 Update libboost to 1.72.0
Closed	serebit	D9709 Rebuild gtkd for ldc update
Closed	serebit	D9693 Update ldc to 1.23.0 and rebuild for LLVM 10
Closed	serebit	D9679 Update LLVM to 10.0.1. Resolves T8843
Closed	serebit	D9682 Initial commit of python-recommonmark
Closed	serebit	D9681 Initial commit of python-commonmark

Update ldc to 1.23.0 and rebuild for LLVM 10
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 23380

abi_symbols

abi_used_libs

files/0001-dont-use-lto-and-or-pgo.patch

files/0001-use-bfd-instead-of-gold.patch

files/dont-force-gold.patch

package.yml

pspec_x86_64.xml

Update ldc to 1.23.0 and rebuild for LLVM 10ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23380

abi_symbols

abi_used_libs

files/0001-dont-use-lto-and-or-pgo.patch

files/0001-use-bfd-instead-of-gold.patch

files/dont-force-gold.patch

package.yml

pspec_x86_64.xml

Update ldc to 1.23.0 and rebuild for LLVM 10
ClosedPublic
Actions

Revision Contents
Changeset List