Page MenuHomeSolus

Update ldc to 1.23.0 and rebuild for LLVM 10
ClosedPublic

Authored by serebit on Sep 19 2020, 5:31 PM.
Tags
None
Referenced Files
F11012099: D9693.diff
Fri, Aug 4, 12:24 AM
F10945232: D9693.id23332.diff
Sat, Jul 15, 3:14 AM
F10911948: D9693.id23375.diff
Jul 7 2023, 11:32 AM
F10859668: D9693.id23341.diff
Jun 16 2023, 5:08 AM
F10850870: D9693.id23331.diff
Jun 12 2023, 7:42 AM
F10847393: D9693.id23332.diff
Jun 11 2023, 10:16 AM
F10843823: D9693.id23380.diff
Jun 10 2023, 7:20 PM
F10828005: D9693.id23375.diff
Jun 4 2023, 8:08 AM
Subscribers

Details

Summary

Rebuilt for LLVM 10 and rebootstrapped. Full release notes for each version between 1.20.1 and 1.23.0 are available here.

Test Plan

Rebuild dub, tilix, and gtkd

Diff Detail

Repository
R4120 ldc
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

serebit retitled this revision from Update ldc to 1.23.0 to Update ldc to 1.23.0 and rebuild for LLVM 10.Sep 20 2020, 3:30 AM
JoshStrobl requested changes to this revision.EditedSep 22 2020, 2:03 PM
JoshStrobl added a subscriber: JoshStrobl.

I'm not seeing gtkd and tilix in the test plan. They're rev deps.

package.yml
10–11

Should be above the BSD license.

This revision now requires changes to proceed.Sep 22 2020, 2:03 PM

Move apache-2.0 license entry

JoshStrobl added inline comments.
files/dont-force-gold.patch
8

They changed the code here, we shouldn't be forcing gold as the linker preference, keep to bfd https://github.com/ldc-developers/ldc/blob/master/driver/linker-gcc.cpp#L573

Really the ArgsBuilder::addLinker function can just do the previous push_back call.

18

We need to re-remove this. They still have it. https://github.com/ldc-developers/ldc/blob/master/CMakeLists.txt#L445

This revision now requires changes to proceed.Sep 22 2020, 2:28 PM

Working on this. Having issues building gtkd with new LDC, need time to look into it. Will hopefully be done by today.

Rebuilt gtkd, required changes. If Tilix succeeds I'll push the gtkd diff and update this, and it should be good to go.

Apply requested changes (don't force gold, don't use LTO/PGO)

This revision is now accepted and ready to land.Sep 23 2020, 11:25 PM