Page MenuHomeSolus

Update ldc to 1.23.0 and rebuild for LLVM 10
ClosedPublic

Authored by serebit on Sep 19 2020, 5:31 PM.

Details

Summary

Rebuilt for LLVM 10 and rebootstrapped. Full release notes for each version between 1.20.1 and 1.23.0 are available here.

Test Plan

Rebuild dub, tilix, and gtkd

Diff Detail

Repository
R4120 ldc
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

serebit created this revision.Sep 19 2020, 5:31 PM
serebit requested review of this revision.Sep 19 2020, 5:31 PM
serebit edited the summary of this revision. (Show Details)Sep 19 2020, 5:31 PM
serebit updated this revision to Diff 23332.Sep 19 2020, 5:32 PM

Remove unused patch

serebit updated this revision to Diff 23341.Sep 19 2020, 8:16 PM

Fix licenses

serebit retitled this revision from Update ldc to 1.23.0 to Update ldc to 1.23.0 and rebuild for LLVM 10.Sep 20 2020, 3:30 AM
JoshStrobl requested changes to this revision.EditedSep 22 2020, 2:03 PM
JoshStrobl added a subscriber: JoshStrobl.

I'm not seeing gtkd and tilix in the test plan. They're rev deps.

package.yml
10–11

Should be above the BSD license.

This revision now requires changes to proceed.Sep 22 2020, 2:03 PM
serebit updated this revision to Diff 23375.Sep 22 2020, 2:14 PM

Move apache-2.0 license entry

JoshStrobl requested changes to this revision.Sep 22 2020, 2:28 PM
JoshStrobl added inline comments.
files/dont-force-gold.patch
8

They changed the code here, we shouldn't be forcing gold as the linker preference, keep to bfd https://github.com/ldc-developers/ldc/blob/master/driver/linker-gcc.cpp#L573

Really the ArgsBuilder::addLinker function can just do the previous push_back call.

18

We need to re-remove this. They still have it. https://github.com/ldc-developers/ldc/blob/master/CMakeLists.txt#L445

This revision now requires changes to proceed.Sep 22 2020, 2:28 PM
serebit marked an inline comment as done.Sep 22 2020, 2:38 PM

Working on this. Having issues building gtkd with new LDC, need time to look into it. Will hopefully be done by today.

Rebuilt gtkd, required changes. If Tilix succeeds I'll push the gtkd diff and update this, and it should be good to go.

serebit updated this revision to Diff 23380.Sep 22 2020, 3:02 PM

Apply requested changes (don't force gold, don't use LTO/PGO)

serebit edited the test plan for this revision. (Show Details)
JoshStrobl accepted this revision.Sep 23 2020, 11:25 PM

LGTM, thanks!

This revision is now accepted and ready to land.Sep 23 2020, 11:25 PM
This revision was automatically updated to reflect the committed changes.
serebit marked 2 inline comments as done.Sep 28 2020, 5:53 PM