Page MenuHomeSolus

Initial inclusion of OpenVDB
ClosedPublic

Authored by Jacek on Wed, Sep 16, 4:29 PM.

Details

Summary

Initial inclusion of OpenVDB. For D9663.

Test Plan

Successfully ompiled Prusa Slicer against it. Still needs testing with Blender.

Diff Detail

Repository
R5056 openvdb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacek created this revision.Wed, Sep 16, 4:29 PM
Jacek requested review of this revision.Wed, Sep 16, 4:29 PM
JoshStrobl requested changes to this revision.Thu, Sep 17, 9:46 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
15

builddeps for pkgconfigs should be 0-9A-Za-z so put IlmBase and OpenEXR above blocs

pspec_x86_64.xml
181

Static should be disabled.

This revision now requires changes to proceed.Thu, Sep 17, 9:46 AM
Jacek added inline comments.Thu, Sep 17, 11:03 AM
pspec_x86_64.xml
181

What do you mean by that? I see no options to disable static in openvdb documentation, not Fedora or Arch do something like that. So I don't know how to disable static.

JoshStrobl added inline comments.Thu, Sep 17, 11:23 AM
Jacek updated this revision to Diff 23299.Thu, Sep 17, 12:24 PM

Reorder builddeps and turn off static.

Jacek marked an inline comment as done.Thu, Sep 17, 12:27 PM
JoshStrobl accepted this revision.Fri, Sep 18, 9:01 AM

LGTM, thanks!

This revision is now accepted and ready to land.Fri, Sep 18, 9:01 AM
This revision was automatically updated to reflect the committed changes.