Page MenuHomeSolus

Initial inclusion of OpenVDB

Authored by Jacek on Sep 16 2020, 4:29 PM.



Initial inclusion of OpenVDB. For D9663.

Test Plan

Successfully ompiled Prusa Slicer against it. Still needs testing with Blender.

Diff Detail

R5056 openvdb
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacek created this revision.Sep 16 2020, 4:29 PM
Jacek requested review of this revision.Sep 16 2020, 4:29 PM
JoshStrobl requested changes to this revision.Sep 17 2020, 9:46 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.

builddeps for pkgconfigs should be 0-9A-Za-z so put IlmBase and OpenEXR above blocs


Static should be disabled.

This revision now requires changes to proceed.Sep 17 2020, 9:46 AM
Jacek added inline comments.Sep 17 2020, 11:03 AM

What do you mean by that? I see no options to disable static in openvdb documentation, not Fedora or Arch do something like that. So I don't know how to disable static.

JoshStrobl added inline comments.Sep 17 2020, 11:23 AM
Jacek updated this revision to Diff 23299.Sep 17 2020, 12:24 PM

Reorder builddeps and turn off static.

Jacek marked an inline comment as done.Sep 17 2020, 12:27 PM
JoshStrobl accepted this revision.Sep 18 2020, 9:01 AM

LGTM, thanks!

This revision is now accepted and ready to land.Sep 18 2020, 9:01 AM
This revision was automatically updated to reflect the committed changes.