Paths

Table of Contentst

Differential D9641

Enable AVX2 for fftw. Resolves T8235
ClosedPublic
Actions

Authored by • serebit on Sep 13 2020, 7:12 PM.

Tags

None

Referenced Files

	F11046824: D9641.diff
	Thu, Aug 10, 2:14 PM

	F11044922: D9641.diff
	Thu, Aug 10, 10:44 AM

	F10890813: D9641.id23219.diff
	Jun 28 2023, 5:20 PM

	F10815515: D9641.id23244.diff
	May 31 2023, 8:56 PM

	F10815438: D9641.id23219.diff
	May 31 2023, 8:28 PM

	F10815309: D9641.diff
	May 31 2023, 7:57 PM

	F10792490: D9641.diff
	May 27 2023, 7:33 AM

	F10738920: D9641.id.diff
	May 13 2023, 3:01 PM

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T8235: Optimizations for fftw package

Commits

R745:42f58bb75533: Enable AVX2 for fftw. Resolves T8235

Summary

In addition to the normal float, double, and long-double FFTW builds, this patch includes AVX2-enabled float and double libs in /usr/lib/haswell.

Resolves T8235.

Test Plan

Run several applications that use FFTW, ensuring that they link against the Haswell libs (gmic, gromacs, hugin, octave).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• serebit created this revision.Sep 13 2020, 7:12 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 13 2020, 7:12 PM

• serebit requested review of this revision.Sep 13 2020, 7:12 PM

• serebit edited the summary of this revision. (Show Details)Sep 13 2020, 7:13 PM

• serebit added a task: T8235: Optimizations for fftw package.

@joebonrichie Mentioned earlier in the thread that it might be worth adding --enable-fma`along with AVX2. Any luck with that?

In D9641#157880, @Jacalz wrote:

@joebonrichie Mentioned earlier in the thread that it might be worth adding --enable-fma`along with AVX2. Any luck with that?

I did! Line 17 contains the flags I used for the AVX2 builds.

Oh gosh, sorry @serebit. I did look though the changes, but it looks like I missed that one. Will rely om ctrl + f in the future :I

Thanks for the hard work. Greatly appreciated :)

In D9641#157883, @Jacalz wrote:

Oh gosh, sorry @serebit. I did look though the changes, but it looks like I missed that one. Will rely om ctrl + f in the future :I

Heh, no worries.

In D9641#157884, @Jacalz wrote:

Thanks for the hard work. Greatly appreciated :)

Happy to help! :D

LGTM, thanks!

This revision is now accepted and ready to land.Sep 15 2020, 9:43 AM

Closed by commit R745:42f58bb75533: Enable AVX2 for fftw. Resolves T8235 (authored by • serebit, committed by JoshStrobl). · Explain WhySep 15 2020, 9:43 AM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R745:42f58bb75533: Enable AVX2 for fftw. Resolves T8235.

Revision Contents
Changeset List

Path

Size

74 lines

pspec_x86_64.xml

26 lines

Diff 23244

package.yml

Loading...

pspec_x86_64.xml

Loading...