Page MenuHomeSolus

Enable AVX2 for fftw. Resolves T8235
ClosedPublic

Authored by serebit on Sep 13 2020, 7:12 PM.

Details

Summary

In addition to the normal float, double, and long-double FFTW builds, this patch includes AVX2-enabled float and double libs in /usr/lib/haswell.

Resolves T8235.

Test Plan

Run several applications that use FFTW, ensuring that they link against the Haswell libs (gmic, gromacs, hugin, octave).

Diff Detail

Repository
R745 fftw
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

serebit created this revision.Sep 13 2020, 7:12 PM
serebit requested review of this revision.Sep 13 2020, 7:12 PM

@joebonrichie Mentioned earlier in the thread that it might be worth adding --enable-fma`along with AVX2. Any luck with that?

@joebonrichie Mentioned earlier in the thread that it might be worth adding --enable-fma`along with AVX2. Any luck with that?

I did! Line 17 contains the flags I used for the AVX2 builds.

Oh gosh, sorry @serebit. I did look though the changes, but it looks like I missed that one. Will rely om ctrl + f in the future :I

Jacalz added a comment.EditedSep 14 2020, 2:57 PM

Thanks for the hard work. Greatly appreciated :)

Oh gosh, sorry @serebit. I did look though the changes, but it looks like I missed that one. Will rely om ctrl + f in the future :I

Heh, no worries.

Thanks for the hard work. Greatly appreciated :)

Happy to help! :D

JoshStrobl accepted this revision.Sep 15 2020, 9:41 AM
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Sep 15 2020, 9:43 AM
This revision was automatically updated to reflect the committed changes.