Page MenuHomeSolus
Differential D9641

Enable AVX2 for fftw. Resolves T8235
ClosedPublic
Actions

Authored by serebit on Sep 13 2020, 7:12 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T8235: Optimizations for fftw package
Commits
R745:42f58bb75533: Enable AVX2 for fftw. Resolves T8235
Summary

In addition to the normal float, double, and long-double FFTW builds, this patch includes AVX2-enabled float and double libs in /usr/lib/haswell.

Resolves T8235.

Test Plan

Run several applications that use FFTW, ensuring that they link against the Haswell libs (gmic, gromacs, hugin, octave).

Diff Detail

Repository
R745 fftw
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

serebit created this revision.Sep 13 2020, 7:12 PM
serebit requested review of this revision.Sep 13 2020, 7:12 PM
Jacalz added subscribers: joebonrichie, Jacalz.Sep 14 2020, 2:42 PM

@joebonrichie Mentioned earlier in the thread that it might be worth adding --enable-fma`along with AVX2. Any luck with that?

serebit added a comment.Sep 14 2020, 2:44 PM
In D9641#157880, @Jacalz wrote:

@joebonrichie Mentioned earlier in the thread that it might be worth adding --enable-fma`along with AVX2. Any luck with that?

I did! Line 17 contains the flags I used for the AVX2 builds.

Jacalz added a comment.Sep 14 2020, 2:56 PM

Oh gosh, sorry @serebit. I did look though the changes, but it looks like I missed that one. Will rely om ctrl + f in the future :I

Jacalz added a comment.EditedSep 14 2020, 2:57 PM

Thanks for the hard work. Greatly appreciated :)

serebit added a comment.Sep 14 2020, 6:12 PM
In D9641#157883, @Jacalz wrote:

Oh gosh, sorry @serebit. I did look though the changes, but it looks like I missed that one. Will rely om ctrl + f in the future :I

Heh, no worries.

In D9641#157884, @Jacalz wrote:

Thanks for the hard work. Greatly appreciated :)

Happy to help! :D

JoshStrobl accepted this revision.Sep 15 2020, 9:41 AM
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Sep 15 2020, 9:43 AM
Closed by commit R745:42f58bb75533: Enable AVX2 for fftw. Resolves T8235 (authored by serebit, committed by JoshStrobl). · Explain WhySep 15 2020, 9:43 AM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R745:42f58bb75533: Enable AVX2 for fftw. Resolves T8235.

Revision Contents
Changeset List

PathPackages
Mpackage.yml (74 lines)
Mpspec_x86_64.xml (26 lines)

Diff 23244

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.