Page MenuHomeSolus

Clean up steam dependencies
ClosedPublic

Authored by Staudey on Sun, Sep 13, 12:41 AM.

Details

Summary

Removed all redundant runtime dependencies.

Test Plan

Installed in a clean Solus VM, updated Steam, launched it, browsed the Store, sent a chat message and installed a game

Diff Detail

Repository
R2962 steam
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Staudey created this revision.Sun, Sep 13, 12:41 AM
Staudey requested review of this revision.Sun, Sep 13, 12:41 AM
Staudey edited the summary of this revision. (Show Details)Sun, Sep 13, 12:46 AM
JoshStrobl requested changes to this revision.Tue, Sep 15, 9:41 AM
JoshStrobl added a subscriber: JoshStrobl.

Otherwise LGTM, thanks for the cleanup.

package.yml
91

This should remain for compatibility with anything that can use the newer NM vs legacy (libnm-legacy-32bit)

This revision now requires changes to proceed.Tue, Sep 15, 9:41 AM
Staudey updated this revision to Diff 23253.Tue, Sep 15, 12:03 PM
Staudey marked an inline comment as done.

Re-add network-manager-32bit dependency, but remove now redundant curl-32bit dep.

package.yml
91

Yeah, that was a bit of a brain fart on my end. What I actually wanted to do was remove the direct dependency on curl-32bit because it gets pulled in by network-manager-32bit, not the other way around. Fixed now.

Staudey updated this revision to Diff 23254.Tue, Sep 15, 12:05 PM

*Actually* add back network-manager-32bit depedency instead of just saying so

JoshStrobl accepted this revision.Tue, Sep 15, 12:12 PM

LGTM, thanks!

This revision is now accepted and ready to land.Tue, Sep 15, 12:12 PM
This revision was automatically updated to reflect the committed changes.