Page MenuHomeSolus

Update CMake to 3.18.2
ClosedPublic

Authored by YakoYakoYokuYoku on Fri, Sep 11, 11:23 PM.

Details

Summary

Link to Changelogs for each of the released versions since 3.17.3:

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Built libzip and a local projectc against the newer CMake.

Diff Detail

Repository
R535 cmake
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Fri, Sep 11, 11:23 PM

Remove Clang line as CMake can be built with GCC (that was not the case in 3.18.1)

As patterns support evidently exists in ypkg should I add cmake-gui or not? Also the doc package only contains copyright and license notices and the documentation actually lives under /usr/share/cmake/Help as reStructuredText files.

JoshStrobl requested changes to this revision.Tue, Sep 15, 9:32 AM
JoshStrobl added a subscriber: JoshStrobl.

should I add cmake-gui or not?

No this is fine as is.

and the documentation actually lives under /usr/share/cmake/Help as reStructuredText files

Then its pattern should be fixed or just dropped entirely.

This revision now requires changes to proceed.Tue, Sep 15, 9:32 AM

Split docs correctly

Run the tests :E

JoshStrobl requested changes to this revision.Tue, Sep 15, 1:09 PM
JoshStrobl added inline comments.
package.yml
20

When we split documentation it's always done to a docs subpackage, not doc.

This revision now requires changes to proceed.Tue, Sep 15, 1:09 PM

Nail the docs correctly ๐Ÿคก

JoshStrobl accepted this revision.Tue, Sep 15, 1:20 PM

LGTM, thanks!

This revision is now accepted and ready to land.Tue, Sep 15, 1:20 PM
This revision was automatically updated to reflect the committed changes.