Page MenuHomeSolus

Update pycodestyle to 2.6.0 and drop python2 support
ClosedPublic

Authored by xulongwu4 on Sep 10 2020, 2:19 AM.
Tags
None
Referenced Files
F11069357: D9622.diff
Fri, Aug 11, 10:51 PM
F11021996: D9622.diff
Mon, Aug 7, 7:46 PM
F10877146: D9622.diff
Jun 20 2023, 4:28 PM
F10851176: D9622.id26207.diff
Jun 12 2023, 10:03 AM
F10846807: D9622.id23185.diff
Jun 11 2023, 7:44 AM
F10825543: D9622.diff
Jun 4 2023, 12:29 AM
F10691594: D9622.diff
Apr 23 2023, 11:12 PM
Subscribers

Details

Summary

Update pycodestyle to 2.6.0 and drop python2 support

Changelog:

  • Fix detection inside async def
  • Fix false positive with chained is not
  • Fix false-negative with decorated functions
  • Allow two blank lines after a block of one-liners
Test Plan
  • Dependency of D9620
  • Used it to check quality of python files successfully

Diff Detail

Repository
R2504 pycodestyle
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

pycodestyle is also required by mutagen and autopep8.

@algent autopep8 is also updated to have compatible versions with pycodestyle. mutagen uses pycodestyle and pyflakes only for code quality check, but it has no functional dependency. mutagen builds successfully with new versions of pycodestyle and the python3 part of unit tests passed. The python2 part of unit tests failed because the drop of python2 support in pycodestyle.

DataDrake added a subscriber: DataDrake.

I think we should look into dropping python2 support in mutagen then.

Otherwise, LGTM. Thanks!

This revision is now accepted and ready to land.Dec 16 2020, 9:12 AM