Paths

Table of Contentst

Differential D9622

Update pycodestyle to 2.6.0 and drop python2 support
ClosedPublic
Actions

Authored by xulongwu4 on Sep 10 2020, 2:19 AM.

Tags

None

Referenced Files

	F11069357: D9622.diff
	Fri, Aug 11, 10:51 PM

	F11021996: D9622.diff
	Mon, Aug 7, 7:46 PM

	F10877146: D9622.diff
	Jun 20 2023, 4:28 PM

	F10851176: D9622.id26207.diff
	Jun 12 2023, 10:03 AM

	F10846807: D9622.id23185.diff
	Jun 11 2023, 7:44 AM

	F10825543: D9622.diff
	Jun 4 2023, 12:29 AM

	F10691594: D9622.diff
	Apr 23 2023, 11:12 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

R2504:3df03e05a068: Update pycodestyle to 2.6.0 and drop python2 support

Summary

Update pycodestyle to 2.6.0 and drop python2 support

Changelog:

Fix detection inside async def
Fix false positive with chained is not
Fix false-negative with decorated functions
Allow two blank lines after a block of one-liners

Test Plan

Dependency of D9620
Used it to check quality of python files successfully

Diff Detail

Repository

R2504 pycodestyle

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

xulongwu4 created this revision.Sep 10 2020, 2:19 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 10 2020, 2:19 AM

xulongwu4 requested review of this revision.Sep 10 2020, 2:19 AM

xulongwu4 added a child revision: D9620: Update flake8 to 3.8.3 and drop python2 support.Sep 10 2020, 2:19 AM

pycodestyle is also required by mutagen and autopep8.

xulongwu4 added a child revision: D9623: Update autopep8 to 1.5.4 and drop python2 support.Sep 10 2020, 11:00 AM

@algent autopep8 is also updated to have compatible versions with pycodestyle. mutagen uses pycodestyle and pyflakes only for code quality check, but it has no functional dependency. mutagen builds successfully with new versions of pycodestyle and the python3 part of unit tests passed. The python2 part of unit tests failed because the drop of python2 support in pycodestyle.

I think we should look into dropping python2 support in mutagen then.

Otherwise, LGTM. Thanks!

This revision is now accepted and ready to land.Dec 16 2020, 9:12 AM

Closed by commit R2504:3df03e05a068: Update pycodestyle to 2.6.0 and drop python2 support (authored by xulongwu4, committed by DataDrake). · Explain WhyApr 23 2021, 11:16 AM

This revision was automatically updated to reflect the committed changes.

DataDrake added a commit: R2504:3df03e05a068: Update pycodestyle to 2.6.0 and drop python2 support.

Revision Contents
Changeset List

Path

Size

16 lines

pspec_x86_64.xml

38 lines

Diff 26207

package.yml

Loading...

pspec_x86_64.xml

Loading...