Page MenuHomeSolus

Update pycodestyle to 2.6.0 and drop python2 support
Needs ReviewPublic

Authored by xulongwu4 on Thu, Sep 10, 2:19 AM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

Update pycodestyle to 2.6.0 and drop python2 support

Changelog:

  • Fix detection inside async def
  • Fix false positive with chained is not
  • Fix false-negative with decorated functions
  • Allow two blank lines after a block of one-liners
Test Plan
  • Dependency of D9620
  • Used it to check quality of python files successfully

Diff Detail

Repository
R2504 pycodestyle
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

xulongwu4 created this revision.Thu, Sep 10, 2:19 AM
xulongwu4 requested review of this revision.Thu, Sep 10, 2:19 AM
algent added a subscriber: algent.EditedThu, Sep 10, 7:17 AM

pycodestyle is also required by mutagen and autopep8.

xulongwu4 added a comment.EditedThu, Sep 10, 11:06 AM

@algent autopep8 is also updated to have compatible versions with pycodestyle. mutagen uses pycodestyle and pyflakes only for code quality check, but it has no functional dependency. mutagen builds successfully with new versions of pycodestyle and the python3 part of unit tests passed. The python2 part of unit tests failed because the drop of python2 support in pycodestyle.