Paths

Table of Contentst

Differential D9621

Update pyflakes to 2.2.0
ClosedPublic
Actions

Authored by xulongwu4 on Sep 10 2020, 2:15 AM.

Tags

None

Referenced Files

	F11069356: D9621.id26208.diff
	Fri, Aug 11, 10:51 PM

	F11069355: D9621.id23184.diff
	Fri, Aug 11, 10:51 PM

	F11069354: D9621.id25113.diff
	Fri, Aug 11, 10:51 PM

	F11069353: D9621.id.diff
	Fri, Aug 11, 10:51 PM

	F11051344: D9621.diff
	Thu, Aug 10, 7:57 PM

	F10848940: D9621.id26208.diff
	Jun 11 2023, 5:17 PM

	F10846864: D9621.id23184.diff
	Jun 11 2023, 8:03 AM

	F10844529: D9621.id25113.diff
	Jun 10 2023, 9:17 PM

View All 15 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R2509:b735f9e92835: Update pyflakes to 2.2.0

Summary

Update pyflakes to 2.2.0

Changelog:

Include column information in error messages
Fix @overload detection with other decorators and in non-global scopes
Fix return-type annotation being a class member
Add check for f-strings without placeholders
Improve python shebang detection
Add support for assignment expressions (PEP 572)
Make pyflakes more resistant to future syntax additions
Fix false positives in partially quoted type annotations
Switch from optparse to argparse
Fix false positives in partially quoted type annotations in unusual contexts

Test Plan

Dependency of D9620.
Used it to check quality of python files successfully.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

xulongwu4 created this revision.Sep 10 2020, 2:15 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 10 2020, 2:15 AM

xulongwu4 requested review of this revision.Sep 10 2020, 2:15 AM

xulongwu4 added a child revision: D9620: Update flake8 to 3.8.3 and drop python2 support.Sep 10 2020, 2:19 AM

Check also python-pycurl and mutagen.

@algent mutagen also uses pyflakes for its code quality check, but it has no functional dependency on pyflakes. mutagen builds successfully and its python3 part of unit tests pass. python-pycurl also only uses pyflakes for unit test. I am able to build python-pycurl successfully. Its unit tests failed. However, this failure happens regardless of whether I use local repository or not, so I don't think it's related to the upgrade of pyflakes.

We should take a closer look at mutagen and python-pycurl, but I think there's nothing wrong here with this patch. LGTM. Thanks!

This revision is now accepted and ready to land.Dec 16 2020, 9:11 AM

algent added a child revision: D10257: Drop test for python-pycurl.Dec 29 2020, 5:53 PM

Submitted the missing patches for python-pycurl and mutagen to complete this stack.

algent mentioned this in D9620: Update flake8 to 3.8.3 and drop python2 support.Jan 22 2021, 1:50 PM

Add back python2 support

xulongwu4 retitled this revision from Update pyflakes to 2.2.0 and drop python2 support to Update pyflakes to 2.2.0.Jan 22 2021, 3:03 PM

xulongwu4 edited the summary of this revision. (Show Details)

algent removed a child revision: D10257: Drop test for python-pycurl.Feb 5 2021, 9:58 AM

Spyder version 5.x series needs this stack.

Closed by commit R2509:b735f9e92835: Update pyflakes to 2.2.0 (authored by xulongwu4, committed by DataDrake). · Explain WhyApr 23 2021, 11:18 AM

This revision was automatically updated to reflect the committed changes.

DataDrake added a commit: R2509:b735f9e92835: Update pyflakes to 2.2.0.

Revision Contents
Changeset List

Path

Size

6 lines

pspec_x86_64.xml

34 lines

Diff 26208

package.yml

Loading...

pspec_x86_64.xml

Loading...