Page MenuHomeSolus

Update pyflakes to 2.2.0 and drop python2 support
Needs ReviewPublic

Authored by xulongwu4 on Thu, Sep 10, 2:15 AM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

Update pyflakes to 2.2.0 and drop python2 support

Changelog:

  • Include column information in error messages
  • Fix @overload detection with other decorators and in non-global scopes
  • Fix return-type annotation being a class member
  • Add check for f-strings without placeholders
  • Improve python shebang detection
  • Add support for assignment expressions (PEP 572)
  • Make pyflakes more resistant to future syntax additions
  • Fix false positives in partially quoted type annotations
  • Switch from optparse to argparse
  • Fix false positives in partially quoted type annotations in unusual contexts
Test Plan
  • Dependency of D9620.
  • Used it to check quality of python files successfully.

Diff Detail

Repository
R2509 pyflakes
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

xulongwu4 created this revision.Thu, Sep 10, 2:15 AM
xulongwu4 requested review of this revision.Thu, Sep 10, 2:15 AM
algent added a subscriber: algent.Thu, Sep 10, 7:26 AM

Check also python-pycurl and mutagen.

@algent mutagen also uses pyflakes for its code quality check, but it has no functional dependency on pyflakes. mutagen builds successfully and its python3 part of unit tests pass. python-pycurl also only uses pyflakes for unit test. I am able to build python-pycurl successfully. Its unit tests failed. However, this failure happens regardless of whether I use local repository or not, so I don't think it's related to the upgrade of pyflakes.