Page MenuHomeSolus

Update python-isort to 5.5.1
ClosedPublic

Authored by xulongwu4 on Tue, Sep 8, 8:28 PM.

Details

Summary

Update python-isort to 5.5.1 and drop python2 support.

Changelog since version 4.3.21.

Test Plan

Used it to sort some python files successfully. Also rebuilt pylint against this version and verified its functionality.

Diff Detail

Repository
R3705 python-isort
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

xulongwu4 created this revision.Tue, Sep 8, 8:28 PM
xulongwu4 requested review of this revision.Tue, Sep 8, 8:28 PM

Switched source to pypi since the github source does not contain a setup.py file.

JoshStrobl requested changes to this revision.Wed, Sep 9, 3:30 PM
JoshStrobl added a subscriber: JoshStrobl.

This needs to be validated with pylint as well please.

This revision now requires changes to proceed.Wed, Sep 9, 3:30 PM
xulongwu4 requested review of this revision.Thu, Sep 10, 1:26 AM
xulongwu4 edited the test plan for this revision. (Show Details)

Tested against pylint. Updated test plan accordingly.

JoshStrobl accepted this revision.Tue, Sep 15, 10:38 AM

LGTM, thanks!

This revision is now accepted and ready to land.Tue, Sep 15, 10:38 AM
This revision was automatically updated to reflect the committed changes.