Page MenuHomeSolus

Update flask-cors to 3.0.9 and enable tests
ClosedPublic

Authored by Staudey on Sat, Sep 5, 11:50 PM.

Details

Summary

Update flask-cors to 3.0.9 and enable tests

Change: Escape path before evaluating resource rules. Prior to this, flask-cors incorrectly
evaluated CORS resource matching before path expansion. E.g. "/api/../foo.txt" would incorrectly match resources for
"/api/*" whereas the path actually expands simply to "/foo.txt"

Test Plan

Build and run Anki with this new version

Diff Detail

Repository
R5049 flask-cors
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Staudey created this revision.Sat, Sep 5, 11:50 PM
Staudey requested review of this revision.Sat, Sep 5, 11:50 PM
Staudey added a project: Restricted Project.Sun, Sep 6, 12:19 AM
JoshStrobl accepted this revision.Wed, Sep 9, 1:58 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Wed, Sep 9, 1:58 PM
This revision was automatically updated to reflect the committed changes.