Update picard to version 1.4.2
ClosedPublic
Actions

Authored by livingsilver94 on Sep 5 2017, 7:17 PM.

Details

Reviewers

• sunnyflunk

Group Reviewers

Triage Team

Commits

R2427:6a89056ae8ec: Update picard to version 1.4.2

Summary

Release notes (please start reading from version 1.3.2): https://picard.musicbrainz.org/changelog/
Package-wise, application description has been extended, during the build phase we followed the
recommended commands from the installation guide, and we removed the inclusion of plugins:
they're not shipped anymore since you can easily download them via Options window, or include
them in your home directory.

Test Plan

Successfully downloaded a plugin and tagged a .flac file.

Diff Detail

Repository

R2427 picard

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

livingsilver94 created this revision.Sep 5 2017, 7:17 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 5 2017, 7:17 PM

I don't know why old release number is 2 instead of (correctly) 3, anyway 4 is OK as a new release number.

In D956#13867, @livingsilver94 wrote:

I don't know why old release number is 2 instead of (correctly) 3, anyway 4 is OK as a new release number.

It means you don't have the latest git (release 3 was April 14) so the patch won't apply. Release 3 is definitely the latest git (and what I have on my system), so this needs to be fixed up.

we removed the inclusion of plugins: they're not shipped anymore since you can easily download them via Options window

Is this true and tested? Cause this is the reason I haven't updated the package, dropping the plugins is a bit of a regression.

This revision now requires changes to proceed.Sep 5 2017, 10:24 PM

joebonrichie added a subscriber: joebonrichie.Sep 5 2017, 10:54 PM

joebonrichie added inline comments.

package.yml
21–23	You should the python macros e.g. `%python_setup build_ext -i` see here for more info https://solus-project.com/articles/packaging/package.yml/en/
23–24	Same here

Fixed diff for package.yml and added macros instead of hard coded commands

we removed the inclusion of plugins: they're not shipped anymore since you can easily download them via Options window

Is this true and tested? Cause this is the reason I haven't updated the package, dropping the plugins is a bit of a regression.

It's true:

It's not a regression, plugins are still here, they just don't come shipped with the package anymore, you can install them via a GUI. Plus, they're now installed in ~/.config/MusicBrainz/picard

Fixed colon alignment

Let me know: when you let a patch idle it's because you forgot about it or you're busy? ?
I'm joking, but still the current Picard version is really old and an update is ready here.

Closed by commit R2427:6a89056ae8ec: Update picard to version 1.4.2 (authored by livingsilver94, committed by • sunnyflunk). · Explain WhySep 12 2017, 9:34 AM

This revision was automatically updated to reflect the committed changes.