Page MenuHomeSolus

Backport canon mraw/sraw regression patch and optimize with LTO
ClosedPublic

Authored by Jacalz on Aug 30 2020, 7:55 PM.
Tags
None
Referenced Files
F11065763: D9548.id23174.diff
Fri, Aug 11, 5:15 PM
F11065762: D9548.id22984.diff
Fri, Aug 11, 5:15 PM
F11065761: D9548.id22985.diff
Fri, Aug 11, 5:15 PM
F11065760: D9548.id.diff
Fri, Aug 11, 5:15 PM
F11065759: D9548.id23120.diff
Fri, Aug 11, 5:15 PM
F11046812: D9548.diff
Thu, Aug 10, 2:13 PM
F11039147: D9548.diff
Thu, Aug 10, 12:14 AM
F10852236: D9548.id23174.diff
Jun 12 2023, 9:58 PM
Subscribers

Details

Summary

This backports a patch that fixes a regression that made Canon SRAW and MRAW files unusable.
It also optimizes using LTO after finding indicated that binaries are both slightly faster and smaller.

Test Plan
  • Ran builtin benchmark and edited raw files.

Diff Detail

Repository
R2788 rawtherapee
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Jacalz updated this revision to Diff 22985.

Actually add patch

I’d like to try and see if clang can bring anything to the table. The files from my new camera is 150% bigger, so every little second that I can remove should make life easier ?

Clang is slower. Don't use it...

Alright. I tried both Clang and PGO which both resulted in slowdowns. I will settle with just LTO for now as it makes the benchmark suite complete roughly 2 seconds faster while having very slight size reductions for the package.

Will try to bring AVX2 to the table some time later as well, but this will have to do until I get computers that actually have support for it. This is now ready for review.

This revision is now accepted and ready to land.Sep 9 2020, 3:39 PM