Page MenuHomeSolus

Backport canon mraw/sraw regression patch and optimize with LTO
ClosedPublic

Authored by Jacalz on Aug 30 2020, 7:55 PM.

Details

Summary

This backports a patch that fixes a regression that made Canon SRAW and MRAW files unusable.
It also optimizes using LTO after finding indicated that binaries are both slightly faster and smaller.

Test Plan
  • Ran builtin benchmark and edited raw files.

Diff Detail

Repository
R2788 rawtherapee
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacalz created this revision.Aug 30 2020, 7:55 PM
Jacalz requested review of this revision.Aug 30 2020, 7:55 PM
Jacalz updated this revision to Diff 22985.

Actually add patch

Jacalz planned changes to this revision.Aug 30 2020, 8:15 PM

Iโ€™d like to try and see if clang can bring anything to the table. The files from my new camera is 150% bigger, so every little second that I can remove should make life easier ๐Ÿ™‚

Jacalz updated this revision to Diff 23120.Sep 7 2020, 2:32 PM

Clang is slower. Don't use it...

Jacalz added a comment.Sep 7 2020, 7:47 PM

Alright. I tried both Clang and PGO which both resulted in slowdowns. I will settle with just LTO for now as it makes the benchmark suite complete roughly 2 seconds faster while having very slight size reductions for the package.

Will try to bring AVX2 to the table some time later as well, but this will have to do until I get computers that actually have support for it. This is now ready for review.

JoshStrobl accepted this revision.Sep 9 2020, 3:39 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Sep 9 2020, 3:39 PM