Page MenuHomeSolus

Initial commit
ClosedPublic

Authored by feskyde on Sep 4 2017, 10:22 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T3950: Foobillard
Commits
R3730:30c5bc620659: Initial commit
Summary

Initial commit for Foobillard++, fixes T3950

Signed-off-by: Federico Damián Schonborn <federicodamiansch@gmail.com>

Test Plan

Played a bit and won a match against the Computer.

Diff Detail

Repository
R3730 foobillardplus
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
feskyde created this revision.Sep 4 2017, 10:22 PM

NOTES: Their build system is a bit flawled af so I had to do some weird things:

  • forced prefix to /usr/share because everything gets installed in /usr (so we get a /usr/foobillardplus directory instead of /usr/share/foobillardplus)
  • moved the files that gets installed in the prefix to their respective places and remove the ones we don't care about
  • I'm not just copying the files instead of running make install because for some strange reason the game didn't load
  • their .desktop file is broken (two Name entries, no categories...), so that's why I'm not using it
DataDrake accepted this revision.Sep 17 2017, 12:13 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Sep 17 2017, 12:13 AM
This revision was automatically updated to reflect the committed changes.