Differential D94

zzip
ClosedPublic
Actions

Authored by Clifspeare on May 11 2017, 3:55 PM.

Tags

None

Referenced Files

	F11021720: D94.diff
	Mon, Aug 7, 5:02 PM

	F11005708: D94.diff
	Tue, Aug 1, 9:28 AM

	F10985753: D94.id267.diff
	Sun, Jul 23, 10:48 PM

	F10944983: D94.id278.diff
	Sat, Jul 15, 2:12 AM

	F10944783: D94.id166.diff
	Sat, Jul 15, 1:13 AM

	F10907356: D94.id166.diff
	Jul 6 2023, 7:24 PM

	F10892240: D94.id184.diff
	Jun 29 2023, 8:33 PM

	F10865446: D94.diff
	Jun 17 2023, 11:38 AM

View All 32 Files

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

Commits

R3475:c20844d92d7c: zzip

Summary

This is a dependency of thrive.

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

Clifspeare created this revision.May 11 2017, 3:55 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMay 11 2017, 3:55 PM

Clifspeare added a task: T2545: Thrive.May 11 2017, 3:56 PM

JoshStrobl requested changes to this revision.May 12 2017, 4:30 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
7	Should be LGPL-2.0
13	python is in system.base, you don't need to specify it.
15	zip is in system.base, you don't need to specify it.
17	Static libraries need to be disabled (check your pspec and the resulting eopkg, has *.a files)
21	Should probably use %make here.

This revision now requires changes to proceed.May 12 2017, 4:30 PM

Thanks

Just one minor bit otherwise LGTM :)

package.yml
15	General convention is to use --disable-static =)

JoshStrobl requested changes to this revision.May 19 2017, 8:39 AM

This revision now requires changes to proceed.May 19 2017, 8:39 AM

Changed --enable-static=no to --disable-static

Corrected component in package.yml.

You added eopkgs. Those needed to be removed.

This revision now requires changes to proceed.May 19 2017, 5:45 PM

Whoops. Removed binary packages.

JoshStrobl accepted this revision.May 19 2017, 6:30 PM

This revision is now accepted and ready to land.May 19 2017, 6:30 PM

Closed by commit R3475:c20844d92d7c: zzip (authored by Clifspeare, committed by JoshStrobl). · Explain WhyMay 26 2017, 2:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

1 line

131 lines

2 lines

20 lines

pspec_x86_64.xml

52 lines

zziplib-0.13.66-1-1-x86_64.eopkg

zziplib-devel-0.13.66-1-1-x86_64.eopkg

Diff 271

Makefile

Loading...

abi_symbols

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...

zziplib-0.13.66-1-1-x86_64.eopkg

Loading...

zziplib-devel-0.13.66-1-1-x86_64.eopkg

Loading...