Page MenuHomeSolus

zzip
ClosedPublic

Authored by Clifspeare on May 11 2017, 3:55 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T2545: Thrive
Commits
R3475:c20844d92d7c: zzip
Summary

This is a dependency of thrive.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Clifspeare created this revision.May 11 2017, 3:55 PM
JoshStrobl requested changes to this revision.May 12 2017, 4:30 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
7

Should be LGPL-2.0

13

python is in system.base, you don't need to specify it.

15

zip is in system.base, you don't need to specify it.

17

Static libraries need to be disabled (check your pspec and the resulting eopkg, has *.a files)

21

Should probably use %make here.

This revision now requires changes to proceed.May 12 2017, 4:30 PM
Clifspeare updated this revision to Diff 184.May 12 2017, 6:23 PM
Clifspeare edited edge metadata.

Thanks

Just one minor bit otherwise LGTM :)

package.yml
14

General convention is to use --disable-static =)

JoshStrobl requested changes to this revision.May 19 2017, 8:39 AM
This revision now requires changes to proceed.May 19 2017, 8:39 AM
Clifspeare updated this revision to Diff 267.May 19 2017, 3:16 PM
Clifspeare edited edge metadata.
Clifspeare marked 5 inline comments as done.

Changed --enable-static=no to --disable-static

Clifspeare updated this revision to Diff 271.May 19 2017, 3:42 PM

Corrected component in package.yml.

JoshStrobl requested changes to this revision.May 19 2017, 5:45 PM

You added eopkgs. Those needed to be removed.

This revision now requires changes to proceed.May 19 2017, 5:45 PM
Clifspeare updated this revision to Diff 278.May 19 2017, 6:26 PM
Clifspeare edited edge metadata.

Whoops. Removed binary packages.

JoshStrobl accepted this revision.May 19 2017, 6:30 PM
This revision is now accepted and ready to land.May 19 2017, 6:30 PM
Closed by commit R3475:c20844d92d7c: zzip (authored by Clifspeare, committed by JoshStrobl). · Explain WhyMay 26 2017, 2:56 PM
This revision was automatically updated to reflect the committed changes.