Details

package.yml
7	Should be LGPL-2.0
13	python is in system.base, you don't need to specify it.
15	zip is in system.base, you don't need to specify it.
17	Static libraries need to be disabled (check your pspec and the resulting eopkg, has *.a files)
21	Should probably use %make here.

This revision now requires changes to proceed.May 12 2017, 4:30 PM

Thanks

Just one minor bit otherwise LGTM :)

package.yml
15	General convention is to use --disable-static =)

JoshStrobl requested changes to this revision.May 19 2017, 8:39 AM

This revision now requires changes to proceed.May 19 2017, 8:39 AM

Changed --enable-static=no to --disable-static

Corrected component in package.yml.

You added eopkgs. Those needed to be removed.

This revision now requires changes to proceed.May 19 2017, 5:45 PM

Whoops. Removed binary packages.

This revision is now accepted and ready to land.May 19 2017, 6:30 PM

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	166	4b825dc		May 11 2017, 3:55 PM	★	★
Diff 2	184	4b825dc	Thanks	May 12 2017, 6:23 PM	★	★
Diff 3	267	4b825dc	Changed --enable-static=no to --disable-static	May 19 2017, 3:16 PM	★	★
Diff 4	271	4b825dc	Corrected component in package.yml.	May 19 2017, 3:42 PM	★	★
Diff 5	278	4b825dc	Whoops. Removed binary packages.	May 19 2017, 6:26 PM	★	★
Diff 6	410	6e724f6	R3475:c20844d92d7cc0e2fd5f84e9bbfc5456bc68ed30	May 26 2017, 2:56 PM	★	★

zzip
ClosedPublic
Actions