Page MenuHomeSolus
Differential D943

Update libhunspell to 1.6.2
ClosedPublic
Actions

Authored by kyrios123 on Sep 3 2017, 1:41 PM.

Details

Reviewers
joebonrichie
Group Reviewers
Triage Team
Commits
R1730:d41b0a2e9a90: Update libhunspell to 1.6.2
Summary

Release notes available on this page

Packaging:

  • format the package.yml
  • add make check
  • review dependencies

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan
  • build & test enchant against this version of hunspell
$ hunspell
Hunspell 1.6.2
hello, world!
*
*

helli, worli!
& helli 5 0: hello, hell, Kelli, hell i, helix
& worli 1 7: world

Diff Detail

Repository
R1730 libhunspell
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kyrios123 created this revision.Sep 3 2017, 1:41 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptSep 3 2017, 1:41 PM
kyrios123 edited the summary of this revision. (Show Details)Sep 3 2017, 1:52 PM
kyrios123 edited the test plan for this revision. (Show Details)Sep 3 2017, 2:13 PM
kyrios123 added a child revision: D944: Update enchant to 2.1.2.Sep 3 2017, 3:05 PM
Justin added a subscriber: Justin.Sep 12 2017, 10:51 AM

I imagine since abi symbols changed that the following would need a rebuild: texstudio aegisub ghostwriter sigil focuswriter codelite libreoffice-common lyx texworks onboard sonnet enchant thunderbird

kyrios123 added a comment.Sep 12 2017, 11:43 AM
In D943#14450, @Justin wrote:

I imagine since abi symbols changed that the following would need a rebuild: texstudio aegisub ghostwriter sigil focuswriter codelite libreoffice-common lyx texworks onboard sonnet enchant thunderbird

For enchant, there is an update in D944 so it needs to be rebuild anyway.
I made a quick test with libreoffice writer and indeed, the spellcheck doesn't work so it should be rebuilt.

kyrios123 mentioned this in D944: Update enchant to 2.1.2.Oct 9 2017, 5:07 PM
kyrios123 mentioned this in D1253: Update firefox to 56.0.2.Oct 25 2017, 9:08 PM
joebonrichie requested changes to this revision.Oct 28 2017, 4:49 PM
joebonrichie added a subscriber: joebonrichie.

I don't mind doing the rebuilds for this, unless you particularly fancy doing them?

package.yml
2

Outdated, 1.6.3 has been released.

This revision now requires changes to proceed.Oct 28 2017, 4:49 PM
joebonrichie added inline comments.Oct 28 2017, 5:10 PM
package.yml
2

Okay, i'm an idiot.

joebonrichie resigned from this revision.Oct 28 2017, 5:11 PM
kyrios123 added a comment.Oct 28 2017, 5:28 PM
In D943#19877, @joebonrichie wrote:

I don't mind doing the rebuilds for this, unless you particularly fancy doing them?

I will do it, I think you already have lot of things on your plate !

joebonrichie accepted this revision.Oct 28 2017, 5:33 PM

Nice, once you've confirmed all the reverse deps are working this is good to go.

This revision is now accepted and ready to land.Oct 28 2017, 5:33 PM
kyrios123 added a comment.EditedOct 28 2017, 7:22 PM

Testing progress

  • aegisub
  • codelite (can be updated after this)
  • enchant
  • firefox (do not forget to enable back hunspell)
  • focuswriter
  • ghostwriter
  • libreoffice-common
  • lyx
  • onboard
  • sigil
  • sonnet
  • texstudio
  • texworks
  • thunderbird
kyrios123 added a subscriber: • sunnyflunk.Oct 29 2017, 12:58 PM

Need some help to check sonnet
I got lot of problems, I tired to check it through a couple of applications like kmail but they are completely broken on my non-plasma desktop. Here are the sonnet relater errors from the logs:

sonnet.core: No language dictionaries for the language: "en"
sonnet.core: No language dictionaries for the language: "en"
sonnet.core: No language dictionaries for the language: "en"
sonnet.core: deleting 0x7fff330724f0 for "en"
sonnet.core: deleting 0x7fff33072288 for "en_US"
sonnet.core: deleting 0x7fff330722f8 for "en_US"
sonnet.core: deleting 0x7fff330722d8 for "en_US"
sonnet.core: deleting 0x7fff33072348 for "en_US"
sonnet.core: No language dictionaries for the language: "en"
sonnet.core: deleting 0x26f3450 for "en"
sonnet.core: deleting 0x26f3008 for "en"

@sunnyflunk perhaps you can help me with this one (hunspell-en is installed on my test machine and I had no problem with other apps) ?

kyrios123 added a comment.Oct 29 2017, 1:36 PM

texworks is working fine but the following trick is required as it is still looking for the deprecated myspell

sudo mkdir -p /usr/share/myspell/dicts
cd /usr/share/myspell/dicts
sudo ln -s /usr/share/hunspell/en_US.aff
sudo ln -s /usr/share/hunspell/en_US.dic
• sunnyflunk added a comment.Oct 30 2017, 8:48 AM
In D943#19961, @kyrios123 wrote:

texworks is working fine but the following trick is required as it is still looking for the deprecated myspell

sudo mkdir -p /usr/share/myspell/dicts
cd /usr/share/myspell/dicts
sudo ln -s /usr/share/hunspell/en_US.aff
sudo ln -s /usr/share/hunspell/en_US.dic

Or we fix it properly via -DTeXworks_DIC_DIR=/usr/share/hunspell

I recommend using kate to test sonnet.

kyrios123 added a comment.Oct 30 2017, 3:16 PM

So the workaround for having spellchecker working on applications using sonnet (basically KDE apps) on non-plasma desktops is to prefix the binary with LANGUAGE=''.
This is not related to this update.

Closed by commit R1730:d41b0a2e9a90: Update libhunspell to 1.6.2 (authored by kyrios123, committed by kyrios123). · Explain WhyOct 30 2017, 4:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3118

View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

component.xml

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.