Page MenuHomeSolus

Update graph-tool to 2.35 and fix T9215
ClosedPublic

Authored by padraig on Aug 6 2020, 2:25 PM.

Details

Summary

Rebuild graph-tool against libboost
Depends on D8527

Update graph-tool to 2.35 and fix T9215

Updates to newest version of graph-tool but does not compile with clang as this causes errors when importing submodules.

Test Plan

Rebuild it against libboost

import graph_tool.correlations

If no error then submodules load okay.

Diff Detail

Repository
R4213 graph-tool
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

padraig requested review of this revision.Aug 6 2020, 2:25 PM
padraig created this revision.
Girtablulu requested changes to this revision.Aug 6 2020, 3:04 PM
Girtablulu added a subscriber: Girtablulu.

please rebase on the correct release, did you forget to make pull before updating it?

This revision now requires changes to proceed.Aug 6 2020, 3:04 PM

Damn it! This is what I thought I did between the last attempt and this one but clearly messed it up somehow.... I'll try again, do I need to build it each time or can I just use these files after making a pull?

you need to rebase, so you will kill these changes because 99% is based on version 9, after rebase you need to run make pull to update it to the latest version, update it to the newest version, build it and update this commit via arc diff -update D9382

padraig updated this revision to Diff 22639.Aug 7 2020, 8:54 AM
  • Update graph-tool to 2.33 and fix T9215

Rebased

you need to rebase, so you will kill these changes because 99% is based on version 9, after rebase you need to run make pull to update it to the latest version, update it to the newest version, build it and update this commit via arc diff -update D9382

Apologies for being so useless here, I'm very inexperienced with github, before I saw your message I cloned it again and then did git config pull.rebase true, then make and updated with acc diff, however it still seems to be on version 8. I did make pull now so hopefully after I've rebuilt it for the 10th time for my sins this will work. It'll take a few hours before I can update it again though.

after rebase and make pull check your package.yml if it's updated, or just reclone the repo add your changes rebuild it and run arc diff --update D9382 which should work as well

padraig updated this revision to Diff 22640.Aug 7 2020, 1:29 PM

Rebased hopefully....

I think it worked finally, sorry about that. Note that I build it with -j2 for memory purposes, that might need to be removed or maybe changed to -j3.

looks good :) but please remove the -j2 from the package.yml, the buildserver can handle this. you dont need to rebuild it just git commit --ammend it and arc diff it

padraig updated this revision to Diff 22641.Aug 7 2020, 3:13 PM

Removed -j2

Should be good now, thanks for your help!

Hi! This should be merged as part of the LLVM upgrade. Could you update this to version 2.35? Would be appreciated.

JoshStrobl requested changes to this revision.Sep 22 2020, 2:08 PM
This revision now requires changes to proceed.Sep 22 2020, 2:08 PM
padraig updated this revision to Diff 23377.Sep 22 2020, 2:24 PM

This is now updated to version 2.35

Summary and title should be updated.

serebit requested changes to this revision.Sep 22 2020, 2:44 PM
serebit retitled this revision from Update graph-tool to 2.33 and fix T9215 to Update graph-tool to 2.35 and fix T9215.
serebit edited the summary of this revision. (Show Details)
This revision now requires changes to proceed.Sep 22 2020, 2:45 PM
serebit resigned from this revision.Sep 22 2020, 2:45 PM
This revision now requires review to proceed.Sep 22 2020, 2:45 PM

Sorry for that. Should be good to go now, @JoshStrobl.

JoshStrobl accepted this revision.Sep 23 2020, 11:26 PM

LGTM, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Sep 28 2020, 8:07 PM
This revision was automatically updated to reflect the committed changes.