Details
- Reviewers
DataDrake Girtablulu JoshStrobl serebit - Group Reviewers
Triage Team - Maniphest Tasks
- T9215: Issue with graph-tool submodules
- Commits
- R4213:ee6c2323dd1b: Update graph-tool to 2.35 and fix T9215
Rebuild it against libboost
import graph_tool.correlations
If no error then submodules load okay.
Diff Detail
- Repository
- R4213 graph-tool
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
please rebase on the correct release, did you forget to make pull before updating it?
Damn it! This is what I thought I did between the last attempt and this one but clearly messed it up somehow.... I'll try again, do I need to build it each time or can I just use these files after making a pull?
you need to rebase, so you will kill these changes because 99% is based on version 9, after rebase you need to run make pull to update it to the latest version, update it to the newest version, build it and update this commit via arc diff -update D9382
Apologies for being so useless here, I'm very inexperienced with github, before I saw your message I cloned it again and then did git config pull.rebase true, then make and updated with acc diff, however it still seems to be on version 8. I did make pull now so hopefully after I've rebuilt it for the 10th time for my sins this will work. It'll take a few hours before I can update it again though.
after rebase and make pull check your package.yml if it's updated, or just reclone the repo add your changes rebuild it and run arc diff --update D9382 which should work as well
I think it worked finally, sorry about that. Note that I build it with -j2 for memory purposes, that might need to be removed or maybe changed to -j3.
looks good :) but please remove the -j2 from the package.yml, the buildserver can handle this. you dont need to rebuild it just git commit --ammend it and arc diff it
Hi! This should be merged as part of the LLVM upgrade. Could you update this to version 2.35? Would be appreciated.