Page MenuHomeSolus

Initial build of mysql-workbench. Completes T243.
AbandonedPublic

Authored by herbmillerjr on Sep 3 2017, 5:31 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T243: MySQL Workbench
Test Plan

Lots of data entry. Graphs and visualization. More data entry. Quick python scripts in the scripting shell. ...and some data entry.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
herbmillerjr created this revision.Sep 3 2017, 5:31 AM
JoshStrobl requested changes to this revision.Sep 13 2017, 9:57 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
8

Needs to be SPDX compliant, GPL-2.0.

14–26

You should be using pkgconfigs where possible.

31–37
This revision now requires changes to proceed.Sep 13 2017, 9:57 AM
JoshStrobl abandoned this revision.Nov 9 2017, 5:42 PM

Abandoning due to lack of movement.

herbmillerjr edited edge metadata.

Made requested corrections and updated to build with new gcc version.

herbmillerjr added a comment.EditedNov 25 2017, 5:40 PM

For reasons unbeknownst to me I had this ready two months ago and never pushed it.

I noticed in testing I've got some weirdness going on with the font on the schema list. The currently selected schema has the same foreground color as the background. I'm not experienced with GTK themes so I might need some help with this.

JoshStrobl requested changes to this revision.Feb 26 2018, 1:07 PM
JoshStrobl added inline comments.
package.yml
5

Should be updated to 6.3.10, was released on November 10th.

23

Is openjdk-8 a rundep as well? If so, should be added there.

31–37

You still need to follow my previous comment on using %apply_patches instead.

39–41

I'd prefer there just be a patch from you that gets applied with your other patches to sort these out instead of sed lines. Far more readable.

This revision now requires changes to proceed.Feb 26 2018, 1:07 PM
JoshStrobl abandoned this revision.Mar 17 2018, 1:20 PM

Closing due to lack of response.